This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
55 lines
1.6 KiB
Go
55 lines
1.6 KiB
Go
//go:build !windows
|
|
|
|
package sockets
|
|
|
|
import (
|
|
"net"
|
|
"os"
|
|
"syscall"
|
|
)
|
|
|
|
// WithChown modifies the socket file's uid and gid
|
|
func WithChown(uid, gid int) SockOption {
|
|
return func(path string) error {
|
|
if err := os.Chown(path, uid, gid); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// WithChmod modifies socket file's access mode.
|
|
func WithChmod(mask os.FileMode) SockOption {
|
|
return func(path string) error {
|
|
if err := os.Chmod(path, mask); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// NewUnixSocket creates a unix socket with the specified path and group.
|
|
func NewUnixSocket(path string, gid int) (net.Listener, error) {
|
|
return NewUnixSocketWithOpts(path, WithChown(0, gid), WithChmod(0o660))
|
|
}
|
|
|
|
func listenUnix(path string) (net.Listener, error) {
|
|
// net.Listen does not allow for permissions to be set. As a result, when
|
|
// specifying custom permissions ("WithChmod()"), there is a short time
|
|
// between creating the socket and applying the permissions, during which
|
|
// the socket permissions are Less restrictive than desired.
|
|
//
|
|
// To work around this limitation of net.Listen(), we temporarily set the
|
|
// umask to 0777, which forces the socket to be created with 000 permissions
|
|
// (i.e.: no access for anyone). After that, WithChmod() must be used to set
|
|
// the desired permissions.
|
|
//
|
|
// We don't use "defer" here, to reset the umask to its original value as soon
|
|
// as possible. Ideally we'd be able to detect if WithChmod() was passed as
|
|
// an option, and skip changing umask if default permissions are used.
|
|
origUmask := syscall.Umask(0o777)
|
|
l, err := net.Listen("unix", path)
|
|
syscall.Umask(origUmask)
|
|
return l, err
|
|
}
|