 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			227 lines
		
	
	
		
			7.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			227 lines
		
	
	
		
			7.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package metric // import "go.opentelemetry.io/otel/metric"
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 
 | |
| 	"go.opentelemetry.io/otel/metric/embedded"
 | |
| )
 | |
| 
 | |
| // Int64Counter is an instrument that records increasing int64 values.
 | |
| //
 | |
| // Warning: Methods may be added to this interface in minor releases. See
 | |
| // package documentation on API implementation for information on how to set
 | |
| // default behavior for unimplemented methods.
 | |
| type Int64Counter interface {
 | |
| 	// Users of the interface can ignore this. This embedded type is only used
 | |
| 	// by implementations of this interface. See the "API Implementations"
 | |
| 	// section of the package documentation for more information.
 | |
| 	embedded.Int64Counter
 | |
| 
 | |
| 	// Add records a change to the counter.
 | |
| 	//
 | |
| 	// Use the WithAttributeSet (or, if performance is not a concern,
 | |
| 	// the WithAttributes) option to include measurement attributes.
 | |
| 	Add(ctx context.Context, incr int64, options ...AddOption)
 | |
| }
 | |
| 
 | |
| // Int64CounterConfig contains options for synchronous counter instruments that
 | |
| // record int64 values.
 | |
| type Int64CounterConfig struct {
 | |
| 	description string
 | |
| 	unit        string
 | |
| }
 | |
| 
 | |
| // NewInt64CounterConfig returns a new [Int64CounterConfig] with all opts
 | |
| // applied.
 | |
| func NewInt64CounterConfig(opts ...Int64CounterOption) Int64CounterConfig {
 | |
| 	var config Int64CounterConfig
 | |
| 	for _, o := range opts {
 | |
| 		config = o.applyInt64Counter(config)
 | |
| 	}
 | |
| 	return config
 | |
| }
 | |
| 
 | |
| // Description returns the configured description.
 | |
| func (c Int64CounterConfig) Description() string {
 | |
| 	return c.description
 | |
| }
 | |
| 
 | |
| // Unit returns the configured unit.
 | |
| func (c Int64CounterConfig) Unit() string {
 | |
| 	return c.unit
 | |
| }
 | |
| 
 | |
| // Int64CounterOption applies options to a [Int64CounterConfig]. See
 | |
| // [InstrumentOption] for other options that can be used as an
 | |
| // Int64CounterOption.
 | |
| type Int64CounterOption interface {
 | |
| 	applyInt64Counter(Int64CounterConfig) Int64CounterConfig
 | |
| }
 | |
| 
 | |
| // Int64UpDownCounter is an instrument that records increasing or decreasing
 | |
| // int64 values.
 | |
| //
 | |
| // Warning: Methods may be added to this interface in minor releases. See
 | |
| // package documentation on API implementation for information on how to set
 | |
| // default behavior for unimplemented methods.
 | |
| type Int64UpDownCounter interface {
 | |
| 	// Users of the interface can ignore this. This embedded type is only used
 | |
| 	// by implementations of this interface. See the "API Implementations"
 | |
| 	// section of the package documentation for more information.
 | |
| 	embedded.Int64UpDownCounter
 | |
| 
 | |
| 	// Add records a change to the counter.
 | |
| 	//
 | |
| 	// Use the WithAttributeSet (or, if performance is not a concern,
 | |
| 	// the WithAttributes) option to include measurement attributes.
 | |
| 	Add(ctx context.Context, incr int64, options ...AddOption)
 | |
| }
 | |
| 
 | |
| // Int64UpDownCounterConfig contains options for synchronous counter
 | |
| // instruments that record int64 values.
 | |
| type Int64UpDownCounterConfig struct {
 | |
| 	description string
 | |
| 	unit        string
 | |
| }
 | |
| 
 | |
| // NewInt64UpDownCounterConfig returns a new [Int64UpDownCounterConfig] with
 | |
| // all opts applied.
 | |
| func NewInt64UpDownCounterConfig(opts ...Int64UpDownCounterOption) Int64UpDownCounterConfig {
 | |
| 	var config Int64UpDownCounterConfig
 | |
| 	for _, o := range opts {
 | |
| 		config = o.applyInt64UpDownCounter(config)
 | |
| 	}
 | |
| 	return config
 | |
| }
 | |
| 
 | |
| // Description returns the configured description.
 | |
| func (c Int64UpDownCounterConfig) Description() string {
 | |
| 	return c.description
 | |
| }
 | |
| 
 | |
| // Unit returns the configured unit.
 | |
| func (c Int64UpDownCounterConfig) Unit() string {
 | |
| 	return c.unit
 | |
| }
 | |
| 
 | |
| // Int64UpDownCounterOption applies options to a [Int64UpDownCounterConfig].
 | |
| // See [InstrumentOption] for other options that can be used as an
 | |
| // Int64UpDownCounterOption.
 | |
| type Int64UpDownCounterOption interface {
 | |
| 	applyInt64UpDownCounter(Int64UpDownCounterConfig) Int64UpDownCounterConfig
 | |
| }
 | |
| 
 | |
| // Int64Histogram is an instrument that records a distribution of int64
 | |
| // values.
 | |
| //
 | |
| // Warning: Methods may be added to this interface in minor releases. See
 | |
| // package documentation on API implementation for information on how to set
 | |
| // default behavior for unimplemented methods.
 | |
| type Int64Histogram interface {
 | |
| 	// Users of the interface can ignore this. This embedded type is only used
 | |
| 	// by implementations of this interface. See the "API Implementations"
 | |
| 	// section of the package documentation for more information.
 | |
| 	embedded.Int64Histogram
 | |
| 
 | |
| 	// Record adds an additional value to the distribution.
 | |
| 	//
 | |
| 	// Use the WithAttributeSet (or, if performance is not a concern,
 | |
| 	// the WithAttributes) option to include measurement attributes.
 | |
| 	Record(ctx context.Context, incr int64, options ...RecordOption)
 | |
| }
 | |
| 
 | |
| // Int64HistogramConfig contains options for synchronous histogram instruments
 | |
| // that record int64 values.
 | |
| type Int64HistogramConfig struct {
 | |
| 	description              string
 | |
| 	unit                     string
 | |
| 	explicitBucketBoundaries []float64
 | |
| }
 | |
| 
 | |
| // NewInt64HistogramConfig returns a new [Int64HistogramConfig] with all opts
 | |
| // applied.
 | |
| func NewInt64HistogramConfig(opts ...Int64HistogramOption) Int64HistogramConfig {
 | |
| 	var config Int64HistogramConfig
 | |
| 	for _, o := range opts {
 | |
| 		config = o.applyInt64Histogram(config)
 | |
| 	}
 | |
| 	return config
 | |
| }
 | |
| 
 | |
| // Description returns the configured description.
 | |
| func (c Int64HistogramConfig) Description() string {
 | |
| 	return c.description
 | |
| }
 | |
| 
 | |
| // Unit returns the configured unit.
 | |
| func (c Int64HistogramConfig) Unit() string {
 | |
| 	return c.unit
 | |
| }
 | |
| 
 | |
| // ExplicitBucketBoundaries returns the configured explicit bucket boundaries.
 | |
| func (c Int64HistogramConfig) ExplicitBucketBoundaries() []float64 {
 | |
| 	return c.explicitBucketBoundaries
 | |
| }
 | |
| 
 | |
| // Int64HistogramOption applies options to a [Int64HistogramConfig]. See
 | |
| // [InstrumentOption] for other options that can be used as an
 | |
| // Int64HistogramOption.
 | |
| type Int64HistogramOption interface {
 | |
| 	applyInt64Histogram(Int64HistogramConfig) Int64HistogramConfig
 | |
| }
 | |
| 
 | |
| // Int64Gauge is an instrument that records instantaneous int64 values.
 | |
| //
 | |
| // Warning: Methods may be added to this interface in minor releases. See
 | |
| // package documentation on API implementation for information on how to set
 | |
| // default behavior for unimplemented methods.
 | |
| type Int64Gauge interface {
 | |
| 	// Users of the interface can ignore this. This embedded type is only used
 | |
| 	// by implementations of this interface. See the "API Implementations"
 | |
| 	// section of the package documentation for more information.
 | |
| 	embedded.Int64Gauge
 | |
| 
 | |
| 	// Record records the instantaneous value.
 | |
| 	//
 | |
| 	// Use the WithAttributeSet (or, if performance is not a concern,
 | |
| 	// the WithAttributes) option to include measurement attributes.
 | |
| 	Record(ctx context.Context, value int64, options ...RecordOption)
 | |
| }
 | |
| 
 | |
| // Int64GaugeConfig contains options for synchronous gauge instruments that
 | |
| // record int64 values.
 | |
| type Int64GaugeConfig struct {
 | |
| 	description string
 | |
| 	unit        string
 | |
| }
 | |
| 
 | |
| // NewInt64GaugeConfig returns a new [Int64GaugeConfig] with all opts
 | |
| // applied.
 | |
| func NewInt64GaugeConfig(opts ...Int64GaugeOption) Int64GaugeConfig {
 | |
| 	var config Int64GaugeConfig
 | |
| 	for _, o := range opts {
 | |
| 		config = o.applyInt64Gauge(config)
 | |
| 	}
 | |
| 	return config
 | |
| }
 | |
| 
 | |
| // Description returns the configured description.
 | |
| func (c Int64GaugeConfig) Description() string {
 | |
| 	return c.description
 | |
| }
 | |
| 
 | |
| // Unit returns the configured unit.
 | |
| func (c Int64GaugeConfig) Unit() string {
 | |
| 	return c.unit
 | |
| }
 | |
| 
 | |
| // Int64GaugeOption applies options to a [Int64GaugeConfig]. See
 | |
| // [InstrumentOption] for other options that can be used as a
 | |
| // Int64GaugeOption.
 | |
| type Int64GaugeOption interface {
 | |
| 	applyInt64Gauge(Int64GaugeConfig) Int64GaugeConfig
 | |
| }
 |