 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			169 lines
		
	
	
		
			5.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			169 lines
		
	
	
		
			5.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package propagation // import "go.opentelemetry.io/otel/propagation"
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"net/http"
 | |
| )
 | |
| 
 | |
| // TextMapCarrier is the storage medium used by a TextMapPropagator.
 | |
| // See ValuesGetter for how a TextMapCarrier can get multiple values for a key.
 | |
| type TextMapCarrier interface {
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| 
 | |
| 	// Get returns the value associated with the passed key.
 | |
| 	Get(key string) string
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| 
 | |
| 	// Set stores the key-value pair.
 | |
| 	Set(key, value string)
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| 
 | |
| 	// Keys lists the keys stored in this carrier.
 | |
| 	Keys() []string
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| }
 | |
| 
 | |
| // ValuesGetter can return multiple values for a single key,
 | |
| // with contrast to TextMapCarrier.Get which returns a single value.
 | |
| type ValuesGetter interface {
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| 
 | |
| 	// Values returns all values associated with the passed key.
 | |
| 	Values(key string) []string
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| }
 | |
| 
 | |
| // MapCarrier is a TextMapCarrier that uses a map held in memory as a storage
 | |
| // medium for propagated key-value pairs.
 | |
| type MapCarrier map[string]string
 | |
| 
 | |
| // Compile time check that MapCarrier implements the TextMapCarrier.
 | |
| var _ TextMapCarrier = MapCarrier{}
 | |
| 
 | |
| // Get returns the value associated with the passed key.
 | |
| func (c MapCarrier) Get(key string) string {
 | |
| 	return c[key]
 | |
| }
 | |
| 
 | |
| // Set stores the key-value pair.
 | |
| func (c MapCarrier) Set(key, value string) {
 | |
| 	c[key] = value
 | |
| }
 | |
| 
 | |
| // Keys lists the keys stored in this carrier.
 | |
| func (c MapCarrier) Keys() []string {
 | |
| 	keys := make([]string, 0, len(c))
 | |
| 	for k := range c {
 | |
| 		keys = append(keys, k)
 | |
| 	}
 | |
| 	return keys
 | |
| }
 | |
| 
 | |
| // HeaderCarrier adapts http.Header to satisfy the TextMapCarrier and ValuesGetter interfaces.
 | |
| type HeaderCarrier http.Header
 | |
| 
 | |
| // Compile time check that HeaderCarrier implements ValuesGetter.
 | |
| var _ TextMapCarrier = HeaderCarrier{}
 | |
| 
 | |
| // Compile time check that HeaderCarrier implements TextMapCarrier.
 | |
| var _ ValuesGetter = HeaderCarrier{}
 | |
| 
 | |
| // Get returns the first value associated with the passed key.
 | |
| func (hc HeaderCarrier) Get(key string) string {
 | |
| 	return http.Header(hc).Get(key)
 | |
| }
 | |
| 
 | |
| // Values returns all values associated with the passed key.
 | |
| func (hc HeaderCarrier) Values(key string) []string {
 | |
| 	return http.Header(hc).Values(key)
 | |
| }
 | |
| 
 | |
| // Set stores the key-value pair.
 | |
| func (hc HeaderCarrier) Set(key, value string) {
 | |
| 	http.Header(hc).Set(key, value)
 | |
| }
 | |
| 
 | |
| // Keys lists the keys stored in this carrier.
 | |
| func (hc HeaderCarrier) Keys() []string {
 | |
| 	keys := make([]string, 0, len(hc))
 | |
| 	for k := range hc {
 | |
| 		keys = append(keys, k)
 | |
| 	}
 | |
| 	return keys
 | |
| }
 | |
| 
 | |
| // TextMapPropagator propagates cross-cutting concerns as key-value text
 | |
| // pairs within a carrier that travels in-band across process boundaries.
 | |
| type TextMapPropagator interface {
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| 
 | |
| 	// Inject set cross-cutting concerns from the Context into the carrier.
 | |
| 	Inject(ctx context.Context, carrier TextMapCarrier)
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| 
 | |
| 	// Extract reads cross-cutting concerns from the carrier into a Context.
 | |
| 	// Implementations may check if the carrier implements ValuesGetter,
 | |
| 	// to support extraction of multiple values per key.
 | |
| 	Extract(ctx context.Context, carrier TextMapCarrier) context.Context
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| 
 | |
| 	// Fields returns the keys whose values are set with Inject.
 | |
| 	Fields() []string
 | |
| 	// DO NOT CHANGE: any modification will not be backwards compatible and
 | |
| 	// must never be done outside of a new major release.
 | |
| }
 | |
| 
 | |
| type compositeTextMapPropagator []TextMapPropagator
 | |
| 
 | |
| func (p compositeTextMapPropagator) Inject(ctx context.Context, carrier TextMapCarrier) {
 | |
| 	for _, i := range p {
 | |
| 		i.Inject(ctx, carrier)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func (p compositeTextMapPropagator) Extract(ctx context.Context, carrier TextMapCarrier) context.Context {
 | |
| 	for _, i := range p {
 | |
| 		ctx = i.Extract(ctx, carrier)
 | |
| 	}
 | |
| 	return ctx
 | |
| }
 | |
| 
 | |
| func (p compositeTextMapPropagator) Fields() []string {
 | |
| 	unique := make(map[string]struct{})
 | |
| 	for _, i := range p {
 | |
| 		for _, k := range i.Fields() {
 | |
| 			unique[k] = struct{}{}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	fields := make([]string, 0, len(unique))
 | |
| 	for k := range unique {
 | |
| 		fields = append(fields, k)
 | |
| 	}
 | |
| 	return fields
 | |
| }
 | |
| 
 | |
| // NewCompositeTextMapPropagator returns a unified TextMapPropagator from the
 | |
| // group of passed TextMapPropagator. This allows different cross-cutting
 | |
| // concerns to be propagates in a unified manner.
 | |
| //
 | |
| // The returned TextMapPropagator will inject and extract cross-cutting
 | |
| // concerns in the order the TextMapPropagators were provided. Additionally,
 | |
| // the Fields method will return a de-duplicated slice of the keys that are
 | |
| // set with the Inject method.
 | |
| func NewCompositeTextMapPropagator(p ...TextMapPropagator) TextMapPropagator {
 | |
| 	return compositeTextMapPropagator(p)
 | |
| }
 |