 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			63 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			63 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019, 2020 OCI Contributors
 | |
| // Copyright 2017 Docker, Inc.
 | |
| //
 | |
| // Licensed under the Apache License, Version 2.0 (the "License");
 | |
| // you may not use this file except in compliance with the License.
 | |
| // You may obtain a copy of the License at
 | |
| //
 | |
| //     https://www.apache.org/licenses/LICENSE-2.0
 | |
| //
 | |
| // Unless required by applicable law or agreed to in writing, software
 | |
| // distributed under the License is distributed on an "AS IS" BASIS,
 | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| // See the License for the specific language governing permissions and
 | |
| // limitations under the License.
 | |
| 
 | |
| // Package digest provides a generalized type to opaquely represent message
 | |
| // digests and their operations within the registry. The Digest type is
 | |
| // designed to serve as a flexible identifier in a content-addressable system.
 | |
| // More importantly, it provides tools and wrappers to work with
 | |
| // hash.Hash-based digests with little effort.
 | |
| //
 | |
| // Basics
 | |
| //
 | |
| // The format of a digest is simply a string with two parts, dubbed the
 | |
| // "algorithm" and the "digest", separated by a colon:
 | |
| //
 | |
| // 	<algorithm>:<digest>
 | |
| //
 | |
| // An example of a sha256 digest representation follows:
 | |
| //
 | |
| // 	sha256:7173b809ca12ec5dee4506cd86be934c4596dd234ee82c0662eac04a8c2c71dc
 | |
| //
 | |
| // The "algorithm" portion defines both the hashing algorithm used to calculate
 | |
| // the digest and the encoding of the resulting digest, which defaults to "hex"
 | |
| // if not otherwise specified. Currently, all supported algorithms have their
 | |
| // digests encoded in hex strings.
 | |
| //
 | |
| // In the example above, the string "sha256" is the algorithm and the hex bytes
 | |
| // are the "digest".
 | |
| //
 | |
| // Because the Digest type is simply a string, once a valid Digest is
 | |
| // obtained, comparisons are cheap, quick and simple to express with the
 | |
| // standard equality operator.
 | |
| //
 | |
| // Verification
 | |
| //
 | |
| // The main benefit of using the Digest type is simple verification against a
 | |
| // given digest. The Verifier interface, modeled after the stdlib hash.Hash
 | |
| // interface, provides a common write sink for digest verification. After
 | |
| // writing is complete, calling the Verifier.Verified method will indicate
 | |
| // whether or not the stream of bytes matches the target digest.
 | |
| //
 | |
| // Missing Features
 | |
| //
 | |
| // In addition to the above, we intend to add the following features to this
 | |
| // package:
 | |
| //
 | |
| // 1. A Digester type that supports write sink digest calculation.
 | |
| //
 | |
| // 2. Suspend and resume of ongoing digest calculations to support efficient digest verification in the registry.
 | |
| //
 | |
| package digest
 |