 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			85 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			85 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
| Package sockets is a simple unix domain socket wrapper.
 | |
| 
 | |
| # Usage
 | |
| 
 | |
| For example:
 | |
| 
 | |
| 	import(
 | |
| 		"fmt"
 | |
| 		"net"
 | |
| 		"os"
 | |
| 		"github.com/docker/go-connections/sockets"
 | |
| 	)
 | |
| 
 | |
| 	func main() {
 | |
| 		l, err := sockets.NewUnixSocketWithOpts("/path/to/sockets",
 | |
| 			sockets.WithChown(0,0),sockets.WithChmod(0660))
 | |
| 		if err != nil {
 | |
| 			panic(err)
 | |
| 		}
 | |
| 		echoStr := "hello"
 | |
| 
 | |
| 		go func() {
 | |
| 			for {
 | |
| 				conn, err := l.Accept()
 | |
| 				if err != nil {
 | |
| 					return
 | |
| 				}
 | |
| 				conn.Write([]byte(echoStr))
 | |
| 				conn.Close()
 | |
| 			}
 | |
| 		}()
 | |
| 
 | |
| 		conn, err := net.Dial("unix", path)
 | |
| 		if err != nil {
 | |
| 			t.Fatal(err)
 | |
| 		}
 | |
| 
 | |
| 		buf := make([]byte, 5)
 | |
| 		if _, err := conn.Read(buf); err != nil {
 | |
| 			panic(err)
 | |
| 		} else if string(buf) != echoStr {
 | |
| 			panic(fmt.Errorf("msg may lost"))
 | |
| 		}
 | |
| 	}
 | |
| */
 | |
| package sockets
 | |
| 
 | |
| import (
 | |
| 	"net"
 | |
| 	"os"
 | |
| 	"syscall"
 | |
| )
 | |
| 
 | |
| // SockOption sets up socket file's creating option
 | |
| type SockOption func(string) error
 | |
| 
 | |
| // NewUnixSocketWithOpts creates a unix socket with the specified options.
 | |
| // By default, socket permissions are 0000 (i.e.: no access for anyone); pass
 | |
| // WithChmod() and WithChown() to set the desired ownership and permissions.
 | |
| //
 | |
| // This function temporarily changes the system's "umask" to 0777 to work around
 | |
| // a race condition between creating the socket and setting its permissions. While
 | |
| // this should only be for a short duration, it may affect other processes that
 | |
| // create files/directories during that period.
 | |
| func NewUnixSocketWithOpts(path string, opts ...SockOption) (net.Listener, error) {
 | |
| 	if err := syscall.Unlink(path); err != nil && !os.IsNotExist(err) {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	l, err := listenUnix(path)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	for _, op := range opts {
 | |
| 		if err := op(path); err != nil {
 | |
| 			_ = l.Close()
 | |
| 			return nil, err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	return l, nil
 | |
| }
 |