 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			121 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			121 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| //go:build go1.21
 | |
| // +build go1.21
 | |
| 
 | |
| /*
 | |
| Copyright 2023 The logr Authors.
 | |
| 
 | |
| Licensed under the Apache License, Version 2.0 (the "License");
 | |
| you may not use this file except in compliance with the License.
 | |
| You may obtain a copy of the License at
 | |
| 
 | |
|     http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
| Unless required by applicable law or agreed to in writing, software
 | |
| distributed under the License is distributed on an "AS IS" BASIS,
 | |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| See the License for the specific language governing permissions and
 | |
| limitations under the License.
 | |
| */
 | |
| 
 | |
| package logr
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"log/slog"
 | |
| 	"runtime"
 | |
| 	"time"
 | |
| )
 | |
| 
 | |
| var (
 | |
| 	_ LogSink          = &slogSink{}
 | |
| 	_ CallDepthLogSink = &slogSink{}
 | |
| 	_ Underlier        = &slogSink{}
 | |
| )
 | |
| 
 | |
| // Underlier is implemented by the LogSink returned by NewFromLogHandler.
 | |
| type Underlier interface {
 | |
| 	// GetUnderlying returns the Handler used by the LogSink.
 | |
| 	GetUnderlying() slog.Handler
 | |
| }
 | |
| 
 | |
| const (
 | |
| 	// nameKey is used to log the `WithName` values as an additional attribute.
 | |
| 	nameKey = "logger"
 | |
| 
 | |
| 	// errKey is used to log the error parameter of Error as an additional attribute.
 | |
| 	errKey = "err"
 | |
| )
 | |
| 
 | |
| type slogSink struct {
 | |
| 	callDepth int
 | |
| 	name      string
 | |
| 	handler   slog.Handler
 | |
| }
 | |
| 
 | |
| func (l *slogSink) Init(info RuntimeInfo) {
 | |
| 	l.callDepth = info.CallDepth
 | |
| }
 | |
| 
 | |
| func (l *slogSink) GetUnderlying() slog.Handler {
 | |
| 	return l.handler
 | |
| }
 | |
| 
 | |
| func (l *slogSink) WithCallDepth(depth int) LogSink {
 | |
| 	newLogger := *l
 | |
| 	newLogger.callDepth += depth
 | |
| 	return &newLogger
 | |
| }
 | |
| 
 | |
| func (l *slogSink) Enabled(level int) bool {
 | |
| 	return l.handler.Enabled(context.Background(), slog.Level(-level))
 | |
| }
 | |
| 
 | |
| func (l *slogSink) Info(level int, msg string, kvList ...interface{}) {
 | |
| 	l.log(nil, msg, slog.Level(-level), kvList...)
 | |
| }
 | |
| 
 | |
| func (l *slogSink) Error(err error, msg string, kvList ...interface{}) {
 | |
| 	l.log(err, msg, slog.LevelError, kvList...)
 | |
| }
 | |
| 
 | |
| func (l *slogSink) log(err error, msg string, level slog.Level, kvList ...interface{}) {
 | |
| 	var pcs [1]uintptr
 | |
| 	// skip runtime.Callers, this function, Info/Error, and all helper functions above that.
 | |
| 	runtime.Callers(3+l.callDepth, pcs[:])
 | |
| 
 | |
| 	record := slog.NewRecord(time.Now(), level, msg, pcs[0])
 | |
| 	if l.name != "" {
 | |
| 		record.AddAttrs(slog.String(nameKey, l.name))
 | |
| 	}
 | |
| 	if err != nil {
 | |
| 		record.AddAttrs(slog.Any(errKey, err))
 | |
| 	}
 | |
| 	record.Add(kvList...)
 | |
| 	_ = l.handler.Handle(context.Background(), record)
 | |
| }
 | |
| 
 | |
| func (l slogSink) WithName(name string) LogSink {
 | |
| 	if l.name != "" {
 | |
| 		l.name += "/"
 | |
| 	}
 | |
| 	l.name += name
 | |
| 	return &l
 | |
| }
 | |
| 
 | |
| func (l slogSink) WithValues(kvList ...interface{}) LogSink {
 | |
| 	l.handler = l.handler.WithAttrs(kvListToAttrs(kvList...))
 | |
| 	return &l
 | |
| }
 | |
| 
 | |
| func kvListToAttrs(kvList ...interface{}) []slog.Attr {
 | |
| 	// We don't need the record itself, only its Add method.
 | |
| 	record := slog.NewRecord(time.Time{}, 0, "", 0)
 | |
| 	record.Add(kvList...)
 | |
| 	attrs := make([]slog.Attr, 0, record.NumAttrs())
 | |
| 	record.Attrs(func(attr slog.Attr) bool {
 | |
| 		attrs = append(attrs, attr)
 | |
| 		return true
 | |
| 	})
 | |
| 	return attrs
 | |
| }
 |