 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			157 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			157 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package propagation // import "go.opentelemetry.io/otel/propagation"
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"encoding/hex"
 | |
| 	"fmt"
 | |
| 	"strings"
 | |
| 
 | |
| 	"go.opentelemetry.io/otel/trace"
 | |
| )
 | |
| 
 | |
| const (
 | |
| 	supportedVersion  = 0
 | |
| 	maxVersion        = 254
 | |
| 	traceparentHeader = "traceparent"
 | |
| 	tracestateHeader  = "tracestate"
 | |
| 	delimiter         = "-"
 | |
| )
 | |
| 
 | |
| // TraceContext is a propagator that supports the W3C Trace Context format
 | |
| // (https://www.w3.org/TR/trace-context/)
 | |
| //
 | |
| // This propagator will propagate the traceparent and tracestate headers to
 | |
| // guarantee traces are not broken. It is up to the users of this propagator
 | |
| // to choose if they want to participate in a trace by modifying the
 | |
| // traceparent header and relevant parts of the tracestate header containing
 | |
| // their proprietary information.
 | |
| type TraceContext struct{}
 | |
| 
 | |
| var (
 | |
| 	_           TextMapPropagator = TraceContext{}
 | |
| 	versionPart                   = fmt.Sprintf("%.2X", supportedVersion)
 | |
| )
 | |
| 
 | |
| // Inject injects the trace context from ctx into carrier.
 | |
| func (TraceContext) Inject(ctx context.Context, carrier TextMapCarrier) {
 | |
| 	sc := trace.SpanContextFromContext(ctx)
 | |
| 	if !sc.IsValid() {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	if ts := sc.TraceState().String(); ts != "" {
 | |
| 		carrier.Set(tracestateHeader, ts)
 | |
| 	}
 | |
| 
 | |
| 	// Clear all flags other than the trace-context supported sampling bit.
 | |
| 	flags := sc.TraceFlags() & trace.FlagsSampled
 | |
| 
 | |
| 	var sb strings.Builder
 | |
| 	sb.Grow(2 + 32 + 16 + 2 + 3)
 | |
| 	_, _ = sb.WriteString(versionPart)
 | |
| 	traceID := sc.TraceID()
 | |
| 	spanID := sc.SpanID()
 | |
| 	flagByte := [1]byte{byte(flags)}
 | |
| 	var buf [32]byte
 | |
| 	for _, src := range [][]byte{traceID[:], spanID[:], flagByte[:]} {
 | |
| 		_ = sb.WriteByte(delimiter[0])
 | |
| 		n := hex.Encode(buf[:], src)
 | |
| 		_, _ = sb.Write(buf[:n])
 | |
| 	}
 | |
| 	carrier.Set(traceparentHeader, sb.String())
 | |
| }
 | |
| 
 | |
| // Extract reads tracecontext from the carrier into a returned Context.
 | |
| //
 | |
| // The returned Context will be a copy of ctx and contain the extracted
 | |
| // tracecontext as the remote SpanContext. If the extracted tracecontext is
 | |
| // invalid, the passed ctx will be returned directly instead.
 | |
| func (tc TraceContext) Extract(ctx context.Context, carrier TextMapCarrier) context.Context {
 | |
| 	sc := tc.extract(carrier)
 | |
| 	if !sc.IsValid() {
 | |
| 		return ctx
 | |
| 	}
 | |
| 	return trace.ContextWithRemoteSpanContext(ctx, sc)
 | |
| }
 | |
| 
 | |
| func (TraceContext) extract(carrier TextMapCarrier) trace.SpanContext {
 | |
| 	h := carrier.Get(traceparentHeader)
 | |
| 	if h == "" {
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 
 | |
| 	var ver [1]byte
 | |
| 	if !extractPart(ver[:], &h, 2) {
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 	version := int(ver[0])
 | |
| 	if version > maxVersion {
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 
 | |
| 	var scc trace.SpanContextConfig
 | |
| 	if !extractPart(scc.TraceID[:], &h, 32) {
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 	if !extractPart(scc.SpanID[:], &h, 16) {
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 
 | |
| 	var opts [1]byte
 | |
| 	if !extractPart(opts[:], &h, 2) {
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 	if version == 0 && (h != "" || opts[0] > 2) {
 | |
| 		// version 0 not allow extra
 | |
| 		// version 0 not allow other flag
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 
 | |
| 	// Clear all flags other than the trace-context supported sampling bit.
 | |
| 	scc.TraceFlags = trace.TraceFlags(opts[0]) & trace.FlagsSampled
 | |
| 
 | |
| 	// Ignore the error returned here. Failure to parse tracestate MUST NOT
 | |
| 	// affect the parsing of traceparent according to the W3C tracecontext
 | |
| 	// specification.
 | |
| 	scc.TraceState, _ = trace.ParseTraceState(carrier.Get(tracestateHeader))
 | |
| 	scc.Remote = true
 | |
| 
 | |
| 	sc := trace.NewSpanContext(scc)
 | |
| 	if !sc.IsValid() {
 | |
| 		return trace.SpanContext{}
 | |
| 	}
 | |
| 
 | |
| 	return sc
 | |
| }
 | |
| 
 | |
| // upperHex detect hex is upper case Unicode characters.
 | |
| func upperHex(v string) bool {
 | |
| 	for _, c := range v {
 | |
| 		if c >= 'A' && c <= 'F' {
 | |
| 			return true
 | |
| 		}
 | |
| 	}
 | |
| 	return false
 | |
| }
 | |
| 
 | |
| func extractPart(dst []byte, h *string, n int) bool {
 | |
| 	part, left, _ := strings.Cut(*h, delimiter)
 | |
| 	*h = left
 | |
| 	// hex.Decode decodes unsupported upper-case characters, so exclude explicitly.
 | |
| 	if len(part) != n || upperHex(part) {
 | |
| 		return false
 | |
| 	}
 | |
| 	if p, err := hex.Decode(dst, []byte(part)); err != nil || p != n/2 {
 | |
| 		return false
 | |
| 	}
 | |
| 	return true
 | |
| }
 | |
| 
 | |
| // Fields returns the keys who's values are set with Inject.
 | |
| func (TraceContext) Fields() []string {
 | |
| 	return []string{traceparentHeader, tracestateHeader}
 | |
| }
 |