 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			82 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			82 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package metric // import "go.opentelemetry.io/otel/metric"
 | |
| 
 | |
| import "go.opentelemetry.io/otel/attribute"
 | |
| 
 | |
| // MeterConfig contains options for Meters.
 | |
| type MeterConfig struct {
 | |
| 	instrumentationVersion string
 | |
| 	schemaURL              string
 | |
| 	attrs                  attribute.Set
 | |
| 
 | |
| 	// Ensure forward compatibility by explicitly making this not comparable.
 | |
| 	noCmp [0]func() //nolint: unused  // This is indeed used.
 | |
| }
 | |
| 
 | |
| // InstrumentationVersion returns the version of the library providing
 | |
| // instrumentation.
 | |
| func (cfg MeterConfig) InstrumentationVersion() string {
 | |
| 	return cfg.instrumentationVersion
 | |
| }
 | |
| 
 | |
| // InstrumentationAttributes returns the attributes associated with the library
 | |
| // providing instrumentation.
 | |
| func (cfg MeterConfig) InstrumentationAttributes() attribute.Set {
 | |
| 	return cfg.attrs
 | |
| }
 | |
| 
 | |
| // SchemaURL is the schema_url of the library providing instrumentation.
 | |
| func (cfg MeterConfig) SchemaURL() string {
 | |
| 	return cfg.schemaURL
 | |
| }
 | |
| 
 | |
| // MeterOption is an interface for applying Meter options.
 | |
| type MeterOption interface {
 | |
| 	// applyMeter is used to set a MeterOption value of a MeterConfig.
 | |
| 	applyMeter(MeterConfig) MeterConfig
 | |
| }
 | |
| 
 | |
| // NewMeterConfig creates a new MeterConfig and applies
 | |
| // all the given options.
 | |
| func NewMeterConfig(opts ...MeterOption) MeterConfig {
 | |
| 	var config MeterConfig
 | |
| 	for _, o := range opts {
 | |
| 		config = o.applyMeter(config)
 | |
| 	}
 | |
| 	return config
 | |
| }
 | |
| 
 | |
| type meterOptionFunc func(MeterConfig) MeterConfig
 | |
| 
 | |
| func (fn meterOptionFunc) applyMeter(cfg MeterConfig) MeterConfig {
 | |
| 	return fn(cfg)
 | |
| }
 | |
| 
 | |
| // WithInstrumentationVersion sets the instrumentation version.
 | |
| func WithInstrumentationVersion(version string) MeterOption {
 | |
| 	return meterOptionFunc(func(config MeterConfig) MeterConfig {
 | |
| 		config.instrumentationVersion = version
 | |
| 		return config
 | |
| 	})
 | |
| }
 | |
| 
 | |
| // WithInstrumentationAttributes sets the instrumentation attributes.
 | |
| //
 | |
| // The passed attributes will be de-duplicated.
 | |
| func WithInstrumentationAttributes(attr ...attribute.KeyValue) MeterOption {
 | |
| 	return meterOptionFunc(func(config MeterConfig) MeterConfig {
 | |
| 		config.attrs = attribute.NewSet(attr...)
 | |
| 		return config
 | |
| 	})
 | |
| }
 | |
| 
 | |
| // WithSchemaURL sets the schema URL.
 | |
| func WithSchemaURL(schemaURL string) MeterOption {
 | |
| 	return meterOptionFunc(func(config MeterConfig) MeterConfig {
 | |
| 		config.schemaURL = schemaURL
 | |
| 		return config
 | |
| 	})
 | |
| }
 |