 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			104 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			104 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package telemetry // import "go.opentelemetry.io/otel/trace/internal/telemetry"
 | |
| 
 | |
| import (
 | |
| 	"encoding/hex"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| )
 | |
| 
 | |
| const (
 | |
| 	traceIDSize = 16
 | |
| 	spanIDSize  = 8
 | |
| )
 | |
| 
 | |
| // TraceID is a custom data type that is used for all trace IDs.
 | |
| type TraceID [traceIDSize]byte
 | |
| 
 | |
| // String returns the hex string representation form of a TraceID.
 | |
| func (tid TraceID) String() string {
 | |
| 	return hex.EncodeToString(tid[:])
 | |
| }
 | |
| 
 | |
| // IsEmpty reports whether the TraceID contains only zero bytes.
 | |
| func (tid TraceID) IsEmpty() bool {
 | |
| 	return tid == [traceIDSize]byte{}
 | |
| }
 | |
| 
 | |
| // MarshalJSON converts the trace ID into a hex string enclosed in quotes.
 | |
| func (tid TraceID) MarshalJSON() ([]byte, error) {
 | |
| 	if tid.IsEmpty() {
 | |
| 		return []byte(`""`), nil
 | |
| 	}
 | |
| 	return marshalJSON(tid[:])
 | |
| }
 | |
| 
 | |
| // UnmarshalJSON inflates the trace ID from hex string, possibly enclosed in
 | |
| // quotes.
 | |
| func (tid *TraceID) UnmarshalJSON(data []byte) error {
 | |
| 	*tid = [traceIDSize]byte{}
 | |
| 	return unmarshalJSON(tid[:], data)
 | |
| }
 | |
| 
 | |
| // SpanID is a custom data type that is used for all span IDs.
 | |
| type SpanID [spanIDSize]byte
 | |
| 
 | |
| // String returns the hex string representation form of a SpanID.
 | |
| func (sid SpanID) String() string {
 | |
| 	return hex.EncodeToString(sid[:])
 | |
| }
 | |
| 
 | |
| // IsEmpty reports whether the SpanID contains only zero bytes.
 | |
| func (sid SpanID) IsEmpty() bool {
 | |
| 	return sid == [spanIDSize]byte{}
 | |
| }
 | |
| 
 | |
| // MarshalJSON converts span ID into a hex string enclosed in quotes.
 | |
| func (sid SpanID) MarshalJSON() ([]byte, error) {
 | |
| 	if sid.IsEmpty() {
 | |
| 		return []byte(`""`), nil
 | |
| 	}
 | |
| 	return marshalJSON(sid[:])
 | |
| }
 | |
| 
 | |
| // UnmarshalJSON decodes span ID from hex string, possibly enclosed in quotes.
 | |
| func (sid *SpanID) UnmarshalJSON(data []byte) error {
 | |
| 	*sid = [spanIDSize]byte{}
 | |
| 	return unmarshalJSON(sid[:], data)
 | |
| }
 | |
| 
 | |
| // marshalJSON converts id into a hex string enclosed in quotes.
 | |
| func marshalJSON(id []byte) ([]byte, error) {
 | |
| 	// Plus 2 quote chars at the start and end.
 | |
| 	hexLen := hex.EncodedLen(len(id)) + 2
 | |
| 
 | |
| 	b := make([]byte, hexLen)
 | |
| 	hex.Encode(b[1:hexLen-1], id)
 | |
| 	b[0], b[hexLen-1] = '"', '"'
 | |
| 
 | |
| 	return b, nil
 | |
| }
 | |
| 
 | |
| // unmarshalJSON inflates trace id from hex string, possibly enclosed in quotes.
 | |
| func unmarshalJSON(dst, src []byte) error {
 | |
| 	if l := len(src); l >= 2 && src[0] == '"' && src[l-1] == '"' {
 | |
| 		src = src[1 : l-1]
 | |
| 	}
 | |
| 	nLen := len(src)
 | |
| 	if nLen == 0 {
 | |
| 		return nil
 | |
| 	}
 | |
| 
 | |
| 	if len(dst) != hex.DecodedLen(nLen) {
 | |
| 		return errors.New("invalid length for ID")
 | |
| 	}
 | |
| 
 | |
| 	_, err := hex.Decode(dst, src)
 | |
| 	if err != nil {
 | |
| 		return fmt.Errorf("cannot unmarshal ID from string '%s': %w", string(src), err)
 | |
| 	}
 | |
| 	return nil
 | |
| }
 |