 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			82 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			82 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package baggage // import "go.opentelemetry.io/otel/internal/baggage"
 | |
| 
 | |
| import "context"
 | |
| 
 | |
| type baggageContextKeyType int
 | |
| 
 | |
| const baggageKey baggageContextKeyType = iota
 | |
| 
 | |
| // SetHookFunc is a callback called when storing baggage in the context.
 | |
| type SetHookFunc func(context.Context, List) context.Context
 | |
| 
 | |
| // GetHookFunc is a callback called when getting baggage from the context.
 | |
| type GetHookFunc func(context.Context, List) List
 | |
| 
 | |
| type baggageState struct {
 | |
| 	list List
 | |
| 
 | |
| 	setHook SetHookFunc
 | |
| 	getHook GetHookFunc
 | |
| }
 | |
| 
 | |
| // ContextWithSetHook returns a copy of parent with hook configured to be
 | |
| // invoked every time ContextWithBaggage is called.
 | |
| //
 | |
| // Passing nil SetHookFunc creates a context with no set hook to call.
 | |
| func ContextWithSetHook(parent context.Context, hook SetHookFunc) context.Context {
 | |
| 	var s baggageState
 | |
| 	if v, ok := parent.Value(baggageKey).(baggageState); ok {
 | |
| 		s = v
 | |
| 	}
 | |
| 
 | |
| 	s.setHook = hook
 | |
| 	return context.WithValue(parent, baggageKey, s)
 | |
| }
 | |
| 
 | |
| // ContextWithGetHook returns a copy of parent with hook configured to be
 | |
| // invoked every time FromContext is called.
 | |
| //
 | |
| // Passing nil GetHookFunc creates a context with no get hook to call.
 | |
| func ContextWithGetHook(parent context.Context, hook GetHookFunc) context.Context {
 | |
| 	var s baggageState
 | |
| 	if v, ok := parent.Value(baggageKey).(baggageState); ok {
 | |
| 		s = v
 | |
| 	}
 | |
| 
 | |
| 	s.getHook = hook
 | |
| 	return context.WithValue(parent, baggageKey, s)
 | |
| }
 | |
| 
 | |
| // ContextWithList returns a copy of parent with baggage. Passing nil list
 | |
| // returns a context without any baggage.
 | |
| func ContextWithList(parent context.Context, list List) context.Context {
 | |
| 	var s baggageState
 | |
| 	if v, ok := parent.Value(baggageKey).(baggageState); ok {
 | |
| 		s = v
 | |
| 	}
 | |
| 
 | |
| 	s.list = list
 | |
| 	ctx := context.WithValue(parent, baggageKey, s)
 | |
| 	if s.setHook != nil {
 | |
| 		ctx = s.setHook(ctx, list)
 | |
| 	}
 | |
| 
 | |
| 	return ctx
 | |
| }
 | |
| 
 | |
| // ListFromContext returns the baggage contained in ctx.
 | |
| func ListFromContext(ctx context.Context) List {
 | |
| 	switch v := ctx.Value(baggageKey).(type) {
 | |
| 	case baggageState:
 | |
| 		if v.getHook != nil {
 | |
| 			return v.getHook(ctx, v.list)
 | |
| 		}
 | |
| 		return v.list
 | |
| 	default:
 | |
| 		return nil
 | |
| 	}
 | |
| }
 |