8d9b62daf3
This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
82 lines
2.5 KiB
Go
82 lines
2.5 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package impl
|
|
|
|
import (
|
|
"bytes"
|
|
"compress/gzip"
|
|
"io"
|
|
"sync"
|
|
|
|
"google.golang.org/protobuf/internal/filedesc"
|
|
"google.golang.org/protobuf/reflect/protoreflect"
|
|
"google.golang.org/protobuf/reflect/protoregistry"
|
|
)
|
|
|
|
// Every enum and message type generated by protoc-gen-go since commit 2fc053c5
|
|
// on February 25th, 2016 has had a method to get the raw descriptor.
|
|
// Types that were not generated by protoc-gen-go or were generated prior
|
|
// to that version are not supported.
|
|
//
|
|
// The []byte returned is the encoded form of a FileDescriptorProto message
|
|
// compressed using GZIP. The []int is the path from the top-level file
|
|
// to the specific message or enum declaration.
|
|
type (
|
|
enumV1 interface {
|
|
EnumDescriptor() ([]byte, []int)
|
|
}
|
|
messageV1 interface {
|
|
Descriptor() ([]byte, []int)
|
|
}
|
|
)
|
|
|
|
var legacyFileDescCache sync.Map // map[*byte]protoreflect.FileDescriptor
|
|
|
|
// legacyLoadFileDesc unmarshals b as a compressed FileDescriptorProto message.
|
|
//
|
|
// This assumes that b is immutable and that b does not refer to part of a
|
|
// concatenated series of GZIP files (which would require shenanigans that
|
|
// rely on the concatenation properties of both protobufs and GZIP).
|
|
// File descriptors generated by protoc-gen-go do not rely on that property.
|
|
func legacyLoadFileDesc(b []byte) protoreflect.FileDescriptor {
|
|
// Fast-path: check whether we already have a cached file descriptor.
|
|
if fd, ok := legacyFileDescCache.Load(&b[0]); ok {
|
|
return fd.(protoreflect.FileDescriptor)
|
|
}
|
|
|
|
// Slow-path: decompress and unmarshal the file descriptor proto.
|
|
zr, err := gzip.NewReader(bytes.NewReader(b))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
b2, err := io.ReadAll(zr)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
fd := filedesc.Builder{
|
|
RawDescriptor: b2,
|
|
FileRegistry: resolverOnly{protoregistry.GlobalFiles}, // do not register back to global registry
|
|
}.Build().File
|
|
if fd, ok := legacyFileDescCache.LoadOrStore(&b[0], fd); ok {
|
|
return fd.(protoreflect.FileDescriptor)
|
|
}
|
|
return fd
|
|
}
|
|
|
|
type resolverOnly struct {
|
|
reg *protoregistry.Files
|
|
}
|
|
|
|
func (r resolverOnly) FindFileByPath(path string) (protoreflect.FileDescriptor, error) {
|
|
return r.reg.FindFileByPath(path)
|
|
}
|
|
func (r resolverOnly) FindDescriptorByName(name protoreflect.FullName) (protoreflect.Descriptor, error) {
|
|
return r.reg.FindDescriptorByName(name)
|
|
}
|
|
func (resolverOnly) RegisterFile(protoreflect.FileDescriptor) error {
|
|
return nil
|
|
}
|