 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			124 lines
		
	
	
		
			3.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			124 lines
		
	
	
		
			3.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package attribute // import "go.opentelemetry.io/otel/attribute"
 | |
| 
 | |
| // Key represents the key part in key-value pairs. It's a string. The
 | |
| // allowed character set in the key depends on the use of the key.
 | |
| type Key string
 | |
| 
 | |
| // Bool creates a KeyValue instance with a BOOL Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- Bool(name, value).
 | |
| func (k Key) Bool(v bool) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: BoolValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // BoolSlice creates a KeyValue instance with a BOOLSLICE Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- BoolSlice(name, value).
 | |
| func (k Key) BoolSlice(v []bool) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: BoolSliceValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Int creates a KeyValue instance with an INT64 Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- Int(name, value).
 | |
| func (k Key) Int(v int) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: IntValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // IntSlice creates a KeyValue instance with an INT64SLICE Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- IntSlice(name, value).
 | |
| func (k Key) IntSlice(v []int) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: IntSliceValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Int64 creates a KeyValue instance with an INT64 Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- Int64(name, value).
 | |
| func (k Key) Int64(v int64) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: Int64Value(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Int64Slice creates a KeyValue instance with an INT64SLICE Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- Int64Slice(name, value).
 | |
| func (k Key) Int64Slice(v []int64) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: Int64SliceValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Float64 creates a KeyValue instance with a FLOAT64 Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- Float64(name, value).
 | |
| func (k Key) Float64(v float64) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: Float64Value(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Float64Slice creates a KeyValue instance with a FLOAT64SLICE Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- Float64(name, value).
 | |
| func (k Key) Float64Slice(v []float64) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: Float64SliceValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // String creates a KeyValue instance with a STRING Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- String(name, value).
 | |
| func (k Key) String(v string) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: StringValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // StringSlice creates a KeyValue instance with a STRINGSLICE Value.
 | |
| //
 | |
| // If creating both a key and value at the same time, use the provided
 | |
| // convenience function instead -- StringSlice(name, value).
 | |
| func (k Key) StringSlice(v []string) KeyValue {
 | |
| 	return KeyValue{
 | |
| 		Key:   k,
 | |
| 		Value: StringSliceValue(v),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Defined reports whether the key is not empty.
 | |
| func (k Key) Defined() bool {
 | |
| 	return len(k) != 0
 | |
| }
 |