 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			116 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			116 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2020 The Go Authors. All rights reserved.
 | |
| // Use of this source code is governed by a BSD-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| // Package order provides ordered access to messages and maps.
 | |
| package order
 | |
| 
 | |
| import (
 | |
| 	"sort"
 | |
| 	"sync"
 | |
| 
 | |
| 	"google.golang.org/protobuf/reflect/protoreflect"
 | |
| )
 | |
| 
 | |
| type messageField struct {
 | |
| 	fd protoreflect.FieldDescriptor
 | |
| 	v  protoreflect.Value
 | |
| }
 | |
| 
 | |
| var messageFieldPool = sync.Pool{
 | |
| 	New: func() any { return new([]messageField) },
 | |
| }
 | |
| 
 | |
| type (
 | |
| 	// FieldRnger is an interface for visiting all fields in a message.
 | |
| 	// The protoreflect.Message type implements this interface.
 | |
| 	FieldRanger interface{ Range(VisitField) }
 | |
| 	// VisitField is called every time a message field is visited.
 | |
| 	VisitField = func(protoreflect.FieldDescriptor, protoreflect.Value) bool
 | |
| )
 | |
| 
 | |
| // RangeFields iterates over the fields of fs according to the specified order.
 | |
| func RangeFields(fs FieldRanger, less FieldOrder, fn VisitField) {
 | |
| 	if less == nil {
 | |
| 		fs.Range(fn)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	// Obtain a pre-allocated scratch buffer.
 | |
| 	p := messageFieldPool.Get().(*[]messageField)
 | |
| 	fields := (*p)[:0]
 | |
| 	defer func() {
 | |
| 		if cap(fields) < 1024 {
 | |
| 			*p = fields
 | |
| 			messageFieldPool.Put(p)
 | |
| 		}
 | |
| 	}()
 | |
| 
 | |
| 	// Collect all fields in the message and sort them.
 | |
| 	fs.Range(func(fd protoreflect.FieldDescriptor, v protoreflect.Value) bool {
 | |
| 		fields = append(fields, messageField{fd, v})
 | |
| 		return true
 | |
| 	})
 | |
| 	sort.Slice(fields, func(i, j int) bool {
 | |
| 		return less(fields[i].fd, fields[j].fd)
 | |
| 	})
 | |
| 
 | |
| 	// Visit the fields in the specified ordering.
 | |
| 	for _, f := range fields {
 | |
| 		if !fn(f.fd, f.v) {
 | |
| 			return
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| type mapEntry struct {
 | |
| 	k protoreflect.MapKey
 | |
| 	v protoreflect.Value
 | |
| }
 | |
| 
 | |
| var mapEntryPool = sync.Pool{
 | |
| 	New: func() any { return new([]mapEntry) },
 | |
| }
 | |
| 
 | |
| type (
 | |
| 	// EntryRanger is an interface for visiting all fields in a message.
 | |
| 	// The protoreflect.Map type implements this interface.
 | |
| 	EntryRanger interface{ Range(VisitEntry) }
 | |
| 	// VisitEntry is called every time a map entry is visited.
 | |
| 	VisitEntry = func(protoreflect.MapKey, protoreflect.Value) bool
 | |
| )
 | |
| 
 | |
| // RangeEntries iterates over the entries of es according to the specified order.
 | |
| func RangeEntries(es EntryRanger, less KeyOrder, fn VisitEntry) {
 | |
| 	if less == nil {
 | |
| 		es.Range(fn)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	// Obtain a pre-allocated scratch buffer.
 | |
| 	p := mapEntryPool.Get().(*[]mapEntry)
 | |
| 	entries := (*p)[:0]
 | |
| 	defer func() {
 | |
| 		if cap(entries) < 1024 {
 | |
| 			*p = entries
 | |
| 			mapEntryPool.Put(p)
 | |
| 		}
 | |
| 	}()
 | |
| 
 | |
| 	// Collect all entries in the map and sort them.
 | |
| 	es.Range(func(k protoreflect.MapKey, v protoreflect.Value) bool {
 | |
| 		entries = append(entries, mapEntry{k, v})
 | |
| 		return true
 | |
| 	})
 | |
| 	sort.Slice(entries, func(i, j int) bool {
 | |
| 		return less(entries[i].k, entries[j].k)
 | |
| 	})
 | |
| 
 | |
| 	// Visit the entries in the specified ordering.
 | |
| 	for _, e := range entries {
 | |
| 		if !fn(e.k, e.v) {
 | |
| 			return
 | |
| 		}
 | |
| 	}
 | |
| }
 |