 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			157 lines
		
	
	
		
			4.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			157 lines
		
	
	
		
			4.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Go Authors. All rights reserved.
 | |
| // Use of this source code is governed by a BSD-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package impl
 | |
| 
 | |
| import (
 | |
| 	"reflect"
 | |
| 	"sync"
 | |
| 	"sync/atomic"
 | |
| 
 | |
| 	"google.golang.org/protobuf/reflect/protoreflect"
 | |
| 	"google.golang.org/protobuf/runtime/protoiface"
 | |
| )
 | |
| 
 | |
| // ExtensionInfo implements ExtensionType.
 | |
| //
 | |
| // This type contains a number of exported fields for legacy compatibility.
 | |
| // The only non-deprecated use of this type is through the methods of the
 | |
| // ExtensionType interface.
 | |
| type ExtensionInfo struct {
 | |
| 	// An ExtensionInfo may exist in several stages of initialization.
 | |
| 	//
 | |
| 	// extensionInfoUninitialized: Some or all of the legacy exported
 | |
| 	// fields may be set, but none of the unexported fields have been
 | |
| 	// initialized. This is the starting state for an ExtensionInfo
 | |
| 	// in legacy generated code.
 | |
| 	//
 | |
| 	// extensionInfoDescInit: The desc field is set, but other unexported fields
 | |
| 	// may not be initialized. Legacy exported fields may or may not be set.
 | |
| 	// This is the starting state for an ExtensionInfo in newly generated code.
 | |
| 	//
 | |
| 	// extensionInfoFullInit: The ExtensionInfo is fully initialized.
 | |
| 	// This state is only entered after lazy initialization is complete.
 | |
| 	init uint32
 | |
| 	mu   sync.Mutex
 | |
| 
 | |
| 	goType reflect.Type
 | |
| 	desc   extensionTypeDescriptor
 | |
| 	conv   Converter
 | |
| 	info   *extensionFieldInfo // for fast-path method implementations
 | |
| 
 | |
| 	// ExtendedType is a typed nil-pointer to the parent message type that
 | |
| 	// is being extended. It is possible for this to be unpopulated in v2
 | |
| 	// since the message may no longer implement the MessageV1 interface.
 | |
| 	//
 | |
| 	// Deprecated: Use the ExtendedType method instead.
 | |
| 	ExtendedType protoiface.MessageV1
 | |
| 
 | |
| 	// ExtensionType is the zero value of the extension type.
 | |
| 	//
 | |
| 	// For historical reasons, reflect.TypeOf(ExtensionType) and the
 | |
| 	// type returned by InterfaceOf may not be identical.
 | |
| 	//
 | |
| 	// Deprecated: Use InterfaceOf(xt.Zero()) instead.
 | |
| 	ExtensionType any
 | |
| 
 | |
| 	// Field is the field number of the extension.
 | |
| 	//
 | |
| 	// Deprecated: Use the Descriptor().Number method instead.
 | |
| 	Field int32
 | |
| 
 | |
| 	// Name is the fully qualified name of extension.
 | |
| 	//
 | |
| 	// Deprecated: Use the Descriptor().FullName method instead.
 | |
| 	Name string
 | |
| 
 | |
| 	// Tag is the protobuf struct tag used in the v1 API.
 | |
| 	//
 | |
| 	// Deprecated: Do not use.
 | |
| 	Tag string
 | |
| 
 | |
| 	// Filename is the proto filename in which the extension is defined.
 | |
| 	//
 | |
| 	// Deprecated: Use Descriptor().ParentFile().Path() instead.
 | |
| 	Filename string
 | |
| }
 | |
| 
 | |
| // Stages of initialization: See the ExtensionInfo.init field.
 | |
| const (
 | |
| 	extensionInfoUninitialized = 0
 | |
| 	extensionInfoDescInit      = 1
 | |
| 	extensionInfoFullInit      = 2
 | |
| )
 | |
| 
 | |
| func InitExtensionInfo(xi *ExtensionInfo, xd protoreflect.ExtensionDescriptor, goType reflect.Type) {
 | |
| 	xi.goType = goType
 | |
| 	xi.desc = extensionTypeDescriptor{xd, xi}
 | |
| 	xi.init = extensionInfoDescInit
 | |
| }
 | |
| 
 | |
| func (xi *ExtensionInfo) New() protoreflect.Value {
 | |
| 	return xi.lazyInit().New()
 | |
| }
 | |
| func (xi *ExtensionInfo) Zero() protoreflect.Value {
 | |
| 	return xi.lazyInit().Zero()
 | |
| }
 | |
| func (xi *ExtensionInfo) ValueOf(v any) protoreflect.Value {
 | |
| 	return xi.lazyInit().PBValueOf(reflect.ValueOf(v))
 | |
| }
 | |
| func (xi *ExtensionInfo) InterfaceOf(v protoreflect.Value) any {
 | |
| 	return xi.lazyInit().GoValueOf(v).Interface()
 | |
| }
 | |
| func (xi *ExtensionInfo) IsValidValue(v protoreflect.Value) bool {
 | |
| 	return xi.lazyInit().IsValidPB(v)
 | |
| }
 | |
| func (xi *ExtensionInfo) IsValidInterface(v any) bool {
 | |
| 	return xi.lazyInit().IsValidGo(reflect.ValueOf(v))
 | |
| }
 | |
| func (xi *ExtensionInfo) TypeDescriptor() protoreflect.ExtensionTypeDescriptor {
 | |
| 	if atomic.LoadUint32(&xi.init) < extensionInfoDescInit {
 | |
| 		xi.lazyInitSlow()
 | |
| 	}
 | |
| 	return &xi.desc
 | |
| }
 | |
| 
 | |
| func (xi *ExtensionInfo) lazyInit() Converter {
 | |
| 	if atomic.LoadUint32(&xi.init) < extensionInfoFullInit {
 | |
| 		xi.lazyInitSlow()
 | |
| 	}
 | |
| 	return xi.conv
 | |
| }
 | |
| 
 | |
| func (xi *ExtensionInfo) lazyInitSlow() {
 | |
| 	xi.mu.Lock()
 | |
| 	defer xi.mu.Unlock()
 | |
| 
 | |
| 	if xi.init == extensionInfoFullInit {
 | |
| 		return
 | |
| 	}
 | |
| 	defer atomic.StoreUint32(&xi.init, extensionInfoFullInit)
 | |
| 
 | |
| 	if xi.desc.ExtensionDescriptor == nil {
 | |
| 		xi.initFromLegacy()
 | |
| 	}
 | |
| 	if !xi.desc.ExtensionDescriptor.IsPlaceholder() {
 | |
| 		if xi.ExtensionType == nil {
 | |
| 			xi.initToLegacy()
 | |
| 		}
 | |
| 		xi.conv = NewConverter(xi.goType, xi.desc.ExtensionDescriptor)
 | |
| 		xi.info = makeExtensionFieldInfo(xi.desc.ExtensionDescriptor)
 | |
| 		xi.info.validation = newValidationInfo(xi.desc.ExtensionDescriptor, xi.goType)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| type extensionTypeDescriptor struct {
 | |
| 	protoreflect.ExtensionDescriptor
 | |
| 	xi *ExtensionInfo
 | |
| }
 | |
| 
 | |
| func (xtd *extensionTypeDescriptor) Type() protoreflect.ExtensionType {
 | |
| 	return xtd.xi
 | |
| }
 | |
| func (xtd *extensionTypeDescriptor) Descriptor() protoreflect.ExtensionDescriptor {
 | |
| 	return xtd.ExtensionDescriptor
 | |
| }
 |