 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			134 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			134 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| //go:build windows
 | |
| // +build windows
 | |
| 
 | |
| package winio
 | |
| 
 | |
| import (
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 	"unsafe"
 | |
| 
 | |
| 	"golang.org/x/sys/windows"
 | |
| )
 | |
| 
 | |
| //sys lookupAccountName(systemName *uint16, accountName string, sid *byte, sidSize *uint32, refDomain *uint16, refDomainSize *uint32, sidNameUse *uint32) (err error) = advapi32.LookupAccountNameW
 | |
| //sys lookupAccountSid(systemName *uint16, sid *byte, name *uint16, nameSize *uint32, refDomain *uint16, refDomainSize *uint32, sidNameUse *uint32) (err error) = advapi32.LookupAccountSidW
 | |
| //sys convertSidToStringSid(sid *byte, str **uint16) (err error) = advapi32.ConvertSidToStringSidW
 | |
| //sys convertStringSidToSid(str *uint16, sid **byte) (err error) = advapi32.ConvertStringSidToSidW
 | |
| 
 | |
| type AccountLookupError struct {
 | |
| 	Name string
 | |
| 	Err  error
 | |
| }
 | |
| 
 | |
| func (e *AccountLookupError) Error() string {
 | |
| 	if e.Name == "" {
 | |
| 		return "lookup account: empty account name specified"
 | |
| 	}
 | |
| 	var s string
 | |
| 	switch {
 | |
| 	case errors.Is(e.Err, windows.ERROR_INVALID_SID):
 | |
| 		s = "the security ID structure is invalid"
 | |
| 	case errors.Is(e.Err, windows.ERROR_NONE_MAPPED):
 | |
| 		s = "not found"
 | |
| 	default:
 | |
| 		s = e.Err.Error()
 | |
| 	}
 | |
| 	return "lookup account " + e.Name + ": " + s
 | |
| }
 | |
| 
 | |
| func (e *AccountLookupError) Unwrap() error { return e.Err }
 | |
| 
 | |
| type SddlConversionError struct {
 | |
| 	Sddl string
 | |
| 	Err  error
 | |
| }
 | |
| 
 | |
| func (e *SddlConversionError) Error() string {
 | |
| 	return "convert " + e.Sddl + ": " + e.Err.Error()
 | |
| }
 | |
| 
 | |
| func (e *SddlConversionError) Unwrap() error { return e.Err }
 | |
| 
 | |
| // LookupSidByName looks up the SID of an account by name
 | |
| //
 | |
| //revive:disable-next-line:var-naming SID, not Sid
 | |
| func LookupSidByName(name string) (sid string, err error) {
 | |
| 	if name == "" {
 | |
| 		return "", &AccountLookupError{name, windows.ERROR_NONE_MAPPED}
 | |
| 	}
 | |
| 
 | |
| 	var sidSize, sidNameUse, refDomainSize uint32
 | |
| 	err = lookupAccountName(nil, name, nil, &sidSize, nil, &refDomainSize, &sidNameUse)
 | |
| 	if err != nil && err != windows.ERROR_INSUFFICIENT_BUFFER { //nolint:errorlint // err is Errno
 | |
| 		return "", &AccountLookupError{name, err}
 | |
| 	}
 | |
| 	sidBuffer := make([]byte, sidSize)
 | |
| 	refDomainBuffer := make([]uint16, refDomainSize)
 | |
| 	err = lookupAccountName(nil, name, &sidBuffer[0], &sidSize, &refDomainBuffer[0], &refDomainSize, &sidNameUse)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{name, err}
 | |
| 	}
 | |
| 	var strBuffer *uint16
 | |
| 	err = convertSidToStringSid(&sidBuffer[0], &strBuffer)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{name, err}
 | |
| 	}
 | |
| 	sid = windows.UTF16ToString((*[0xffff]uint16)(unsafe.Pointer(strBuffer))[:])
 | |
| 	_, _ = windows.LocalFree(windows.Handle(unsafe.Pointer(strBuffer)))
 | |
| 	return sid, nil
 | |
| }
 | |
| 
 | |
| // LookupNameBySid looks up the name of an account by SID
 | |
| //
 | |
| //revive:disable-next-line:var-naming SID, not Sid
 | |
| func LookupNameBySid(sid string) (name string, err error) {
 | |
| 	if sid == "" {
 | |
| 		return "", &AccountLookupError{sid, windows.ERROR_NONE_MAPPED}
 | |
| 	}
 | |
| 
 | |
| 	sidBuffer, err := windows.UTF16PtrFromString(sid)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 
 | |
| 	var sidPtr *byte
 | |
| 	if err = convertStringSidToSid(sidBuffer, &sidPtr); err != nil {
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 	defer windows.LocalFree(windows.Handle(unsafe.Pointer(sidPtr))) //nolint:errcheck
 | |
| 
 | |
| 	var nameSize, refDomainSize, sidNameUse uint32
 | |
| 	err = lookupAccountSid(nil, sidPtr, nil, &nameSize, nil, &refDomainSize, &sidNameUse)
 | |
| 	if err != nil && err != windows.ERROR_INSUFFICIENT_BUFFER { //nolint:errorlint // err is Errno
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 
 | |
| 	nameBuffer := make([]uint16, nameSize)
 | |
| 	refDomainBuffer := make([]uint16, refDomainSize)
 | |
| 	err = lookupAccountSid(nil, sidPtr, &nameBuffer[0], &nameSize, &refDomainBuffer[0], &refDomainSize, &sidNameUse)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 
 | |
| 	name = windows.UTF16ToString(nameBuffer)
 | |
| 	return name, nil
 | |
| }
 | |
| 
 | |
| func SddlToSecurityDescriptor(sddl string) ([]byte, error) {
 | |
| 	sd, err := windows.SecurityDescriptorFromString(sddl)
 | |
| 	if err != nil {
 | |
| 		return nil, &SddlConversionError{Sddl: sddl, Err: err}
 | |
| 	}
 | |
| 	b := unsafe.Slice((*byte)(unsafe.Pointer(sd)), sd.Length())
 | |
| 	return b, nil
 | |
| }
 | |
| 
 | |
| func SecurityDescriptorToSddl(sd []byte) (string, error) {
 | |
| 	if l := int(unsafe.Sizeof(windows.SECURITY_DESCRIPTOR{})); len(sd) < l {
 | |
| 		return "", fmt.Errorf("SecurityDescriptor (%d) smaller than expected (%d): %w", len(sd), l, windows.ERROR_INCORRECT_SIZE)
 | |
| 	}
 | |
| 	s := (*windows.SECURITY_DESCRIPTOR)(unsafe.Pointer(&sd[0]))
 | |
| 	return s.String(), nil
 | |
| }
 |