 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			190 lines
		
	
	
		
			4.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			190 lines
		
	
	
		
			4.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package telemetry // import "go.opentelemetry.io/otel/trace/internal/telemetry"
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"encoding/json"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 	"io"
 | |
| )
 | |
| 
 | |
| // Traces represents the traces data that can be stored in a persistent storage,
 | |
| // OR can be embedded by other protocols that transfer OTLP traces data but do
 | |
| // not implement the OTLP protocol.
 | |
| //
 | |
| // The main difference between this message and collector protocol is that
 | |
| // in this message there will not be any "control" or "metadata" specific to
 | |
| // OTLP protocol.
 | |
| //
 | |
| // When new fields are added into this message, the OTLP request MUST be updated
 | |
| // as well.
 | |
| type Traces struct {
 | |
| 	// An array of ResourceSpans.
 | |
| 	// For data coming from a single resource this array will typically contain
 | |
| 	// one element. Intermediary nodes that receive data from multiple origins
 | |
| 	// typically batch the data before forwarding further and in that case this
 | |
| 	// array will contain multiple elements.
 | |
| 	ResourceSpans []*ResourceSpans `json:"resourceSpans,omitempty"`
 | |
| }
 | |
| 
 | |
| // UnmarshalJSON decodes the OTLP formatted JSON contained in data into td.
 | |
| func (td *Traces) UnmarshalJSON(data []byte) error {
 | |
| 	decoder := json.NewDecoder(bytes.NewReader(data))
 | |
| 
 | |
| 	t, err := decoder.Token()
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	if t != json.Delim('{') {
 | |
| 		return errors.New("invalid TracesData type")
 | |
| 	}
 | |
| 
 | |
| 	for decoder.More() {
 | |
| 		keyIface, err := decoder.Token()
 | |
| 		if err != nil {
 | |
| 			if errors.Is(err, io.EOF) {
 | |
| 				// Empty.
 | |
| 				return nil
 | |
| 			}
 | |
| 			return err
 | |
| 		}
 | |
| 
 | |
| 		key, ok := keyIface.(string)
 | |
| 		if !ok {
 | |
| 			return fmt.Errorf("invalid TracesData field: %#v", keyIface)
 | |
| 		}
 | |
| 
 | |
| 		switch key {
 | |
| 		case "resourceSpans", "resource_spans":
 | |
| 			err = decoder.Decode(&td.ResourceSpans)
 | |
| 		default:
 | |
| 			// Skip unknown.
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // ResourceSpans is a collection of ScopeSpans from a Resource.
 | |
| type ResourceSpans struct {
 | |
| 	// The resource for the spans in this message.
 | |
| 	// If this field is not set then no resource info is known.
 | |
| 	Resource Resource `json:"resource"`
 | |
| 	// A list of ScopeSpans that originate from a resource.
 | |
| 	ScopeSpans []*ScopeSpans `json:"scopeSpans,omitempty"`
 | |
| 	// This schema_url applies to the data in the "resource" field. It does not apply
 | |
| 	// to the data in the "scope_spans" field which have their own schema_url field.
 | |
| 	SchemaURL string `json:"schemaUrl,omitempty"`
 | |
| }
 | |
| 
 | |
| // UnmarshalJSON decodes the OTLP formatted JSON contained in data into rs.
 | |
| func (rs *ResourceSpans) UnmarshalJSON(data []byte) error {
 | |
| 	decoder := json.NewDecoder(bytes.NewReader(data))
 | |
| 
 | |
| 	t, err := decoder.Token()
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	if t != json.Delim('{') {
 | |
| 		return errors.New("invalid ResourceSpans type")
 | |
| 	}
 | |
| 
 | |
| 	for decoder.More() {
 | |
| 		keyIface, err := decoder.Token()
 | |
| 		if err != nil {
 | |
| 			if errors.Is(err, io.EOF) {
 | |
| 				// Empty.
 | |
| 				return nil
 | |
| 			}
 | |
| 			return err
 | |
| 		}
 | |
| 
 | |
| 		key, ok := keyIface.(string)
 | |
| 		if !ok {
 | |
| 			return fmt.Errorf("invalid ResourceSpans field: %#v", keyIface)
 | |
| 		}
 | |
| 
 | |
| 		switch key {
 | |
| 		case "resource":
 | |
| 			err = decoder.Decode(&rs.Resource)
 | |
| 		case "scopeSpans", "scope_spans":
 | |
| 			err = decoder.Decode(&rs.ScopeSpans)
 | |
| 		case "schemaUrl", "schema_url":
 | |
| 			err = decoder.Decode(&rs.SchemaURL)
 | |
| 		default:
 | |
| 			// Skip unknown.
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // ScopeSpans is a collection of Spans produced by an InstrumentationScope.
 | |
| type ScopeSpans struct {
 | |
| 	// The instrumentation scope information for the spans in this message.
 | |
| 	// Semantically when InstrumentationScope isn't set, it is equivalent with
 | |
| 	// an empty instrumentation scope name (unknown).
 | |
| 	Scope *Scope `json:"scope"`
 | |
| 	// A list of Spans that originate from an instrumentation scope.
 | |
| 	Spans []*Span `json:"spans,omitempty"`
 | |
| 	// The Schema URL, if known. This is the identifier of the Schema that the span data
 | |
| 	// is recorded in. To learn more about Schema URL see
 | |
| 	// https://opentelemetry.io/docs/specs/otel/schemas/#schema-url
 | |
| 	// This schema_url applies to all spans and span events in the "spans" field.
 | |
| 	SchemaURL string `json:"schemaUrl,omitempty"`
 | |
| }
 | |
| 
 | |
| // UnmarshalJSON decodes the OTLP formatted JSON contained in data into ss.
 | |
| func (ss *ScopeSpans) UnmarshalJSON(data []byte) error {
 | |
| 	decoder := json.NewDecoder(bytes.NewReader(data))
 | |
| 
 | |
| 	t, err := decoder.Token()
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	if t != json.Delim('{') {
 | |
| 		return errors.New("invalid ScopeSpans type")
 | |
| 	}
 | |
| 
 | |
| 	for decoder.More() {
 | |
| 		keyIface, err := decoder.Token()
 | |
| 		if err != nil {
 | |
| 			if errors.Is(err, io.EOF) {
 | |
| 				// Empty.
 | |
| 				return nil
 | |
| 			}
 | |
| 			return err
 | |
| 		}
 | |
| 
 | |
| 		key, ok := keyIface.(string)
 | |
| 		if !ok {
 | |
| 			return fmt.Errorf("invalid ScopeSpans field: %#v", keyIface)
 | |
| 		}
 | |
| 
 | |
| 		switch key {
 | |
| 		case "scope":
 | |
| 			err = decoder.Decode(&ss.Scope)
 | |
| 		case "spans":
 | |
| 			err = decoder.Decode(&ss.Spans)
 | |
| 		case "schemaUrl", "schema_url":
 | |
| 			err = decoder.Decode(&ss.SchemaURL)
 | |
| 		default:
 | |
| 			// Skip unknown.
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 	return nil
 | |
| }
 |