 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			152 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			152 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright The OpenTelemetry Authors
 | |
| // SPDX-License-Identifier: Apache-2.0
 | |
| 
 | |
| package attribute // import "go.opentelemetry.io/otel/attribute"
 | |
| 
 | |
| // Iterator allows iterating over the set of attributes in order, sorted by
 | |
| // key.
 | |
| type Iterator struct {
 | |
| 	storage *Set
 | |
| 	idx     int
 | |
| }
 | |
| 
 | |
| // MergeIterator supports iterating over two sets of attributes while
 | |
| // eliminating duplicate values from the combined set. The first iterator
 | |
| // value takes precedence.
 | |
| type MergeIterator struct {
 | |
| 	one     oneIterator
 | |
| 	two     oneIterator
 | |
| 	current KeyValue
 | |
| }
 | |
| 
 | |
| type oneIterator struct {
 | |
| 	iter Iterator
 | |
| 	done bool
 | |
| 	attr KeyValue
 | |
| }
 | |
| 
 | |
| // Next moves the iterator to the next position.
 | |
| // Next reports whether there are more attributes.
 | |
| func (i *Iterator) Next() bool {
 | |
| 	i.idx++
 | |
| 	return i.idx < i.Len()
 | |
| }
 | |
| 
 | |
| // Label returns current KeyValue. Must be called only after Next returns
 | |
| // true.
 | |
| //
 | |
| // Deprecated: Use Attribute instead.
 | |
| func (i *Iterator) Label() KeyValue {
 | |
| 	return i.Attribute()
 | |
| }
 | |
| 
 | |
| // Attribute returns the current KeyValue of the Iterator. It must be called
 | |
| // only after Next returns true.
 | |
| func (i *Iterator) Attribute() KeyValue {
 | |
| 	kv, _ := i.storage.Get(i.idx)
 | |
| 	return kv
 | |
| }
 | |
| 
 | |
| // IndexedLabel returns current index and attribute. Must be called only
 | |
| // after Next returns true.
 | |
| //
 | |
| // Deprecated: Use IndexedAttribute instead.
 | |
| func (i *Iterator) IndexedLabel() (int, KeyValue) {
 | |
| 	return i.idx, i.Attribute()
 | |
| }
 | |
| 
 | |
| // IndexedAttribute returns current index and attribute. Must be called only
 | |
| // after Next returns true.
 | |
| func (i *Iterator) IndexedAttribute() (int, KeyValue) {
 | |
| 	return i.idx, i.Attribute()
 | |
| }
 | |
| 
 | |
| // Len returns a number of attributes in the iterated set.
 | |
| func (i *Iterator) Len() int {
 | |
| 	return i.storage.Len()
 | |
| }
 | |
| 
 | |
| // ToSlice is a convenience function that creates a slice of attributes from
 | |
| // the passed iterator. The iterator is set up to start from the beginning
 | |
| // before creating the slice.
 | |
| func (i *Iterator) ToSlice() []KeyValue {
 | |
| 	l := i.Len()
 | |
| 	if l == 0 {
 | |
| 		return nil
 | |
| 	}
 | |
| 	i.idx = -1
 | |
| 	slice := make([]KeyValue, 0, l)
 | |
| 	for i.Next() {
 | |
| 		slice = append(slice, i.Attribute())
 | |
| 	}
 | |
| 	return slice
 | |
| }
 | |
| 
 | |
| // NewMergeIterator returns a MergeIterator for merging two attribute sets.
 | |
| // Duplicates are resolved by taking the value from the first set.
 | |
| func NewMergeIterator(s1, s2 *Set) MergeIterator {
 | |
| 	mi := MergeIterator{
 | |
| 		one: makeOne(s1.Iter()),
 | |
| 		two: makeOne(s2.Iter()),
 | |
| 	}
 | |
| 	return mi
 | |
| }
 | |
| 
 | |
| func makeOne(iter Iterator) oneIterator {
 | |
| 	oi := oneIterator{
 | |
| 		iter: iter,
 | |
| 	}
 | |
| 	oi.advance()
 | |
| 	return oi
 | |
| }
 | |
| 
 | |
| func (oi *oneIterator) advance() {
 | |
| 	if oi.done = !oi.iter.Next(); !oi.done {
 | |
| 		oi.attr = oi.iter.Attribute()
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Next moves the iterator to the next position.
 | |
| // Next reports whether there is another attribute available.
 | |
| func (m *MergeIterator) Next() bool {
 | |
| 	if m.one.done && m.two.done {
 | |
| 		return false
 | |
| 	}
 | |
| 	if m.one.done {
 | |
| 		m.current = m.two.attr
 | |
| 		m.two.advance()
 | |
| 		return true
 | |
| 	}
 | |
| 	if m.two.done {
 | |
| 		m.current = m.one.attr
 | |
| 		m.one.advance()
 | |
| 		return true
 | |
| 	}
 | |
| 	if m.one.attr.Key == m.two.attr.Key {
 | |
| 		m.current = m.one.attr // first iterator attribute value wins
 | |
| 		m.one.advance()
 | |
| 		m.two.advance()
 | |
| 		return true
 | |
| 	}
 | |
| 	if m.one.attr.Key < m.two.attr.Key {
 | |
| 		m.current = m.one.attr
 | |
| 		m.one.advance()
 | |
| 		return true
 | |
| 	}
 | |
| 	m.current = m.two.attr
 | |
| 	m.two.advance()
 | |
| 	return true
 | |
| }
 | |
| 
 | |
| // Label returns the current value after Next() returns true.
 | |
| //
 | |
| // Deprecated: Use Attribute instead.
 | |
| func (m *MergeIterator) Label() KeyValue {
 | |
| 	return m.current
 | |
| }
 | |
| 
 | |
| // Attribute returns the current value after Next() returns true.
 | |
| func (m *MergeIterator) Attribute() KeyValue {
 | |
| 	return m.current
 | |
| }
 |