 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			122 lines
		
	
	
		
			3.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			122 lines
		
	
	
		
			3.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2018 The Go Authors. All rights reserved.
 | |
| // Use of this source code is governed by a BSD-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package impl
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"reflect"
 | |
| 
 | |
| 	"google.golang.org/protobuf/reflect/protoreflect"
 | |
| )
 | |
| 
 | |
| type mapConverter struct {
 | |
| 	goType           reflect.Type // map[K]V
 | |
| 	keyConv, valConv Converter
 | |
| }
 | |
| 
 | |
| func newMapConverter(t reflect.Type, fd protoreflect.FieldDescriptor) *mapConverter {
 | |
| 	if t.Kind() != reflect.Map {
 | |
| 		panic(fmt.Sprintf("invalid Go type %v for field %v", t, fd.FullName()))
 | |
| 	}
 | |
| 	return &mapConverter{
 | |
| 		goType:  t,
 | |
| 		keyConv: newSingularConverter(t.Key(), fd.MapKey()),
 | |
| 		valConv: newSingularConverter(t.Elem(), fd.MapValue()),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func (c *mapConverter) PBValueOf(v reflect.Value) protoreflect.Value {
 | |
| 	if v.Type() != c.goType {
 | |
| 		panic(fmt.Sprintf("invalid type: got %v, want %v", v.Type(), c.goType))
 | |
| 	}
 | |
| 	return protoreflect.ValueOfMap(&mapReflect{v, c.keyConv, c.valConv})
 | |
| }
 | |
| 
 | |
| func (c *mapConverter) GoValueOf(v protoreflect.Value) reflect.Value {
 | |
| 	return v.Map().(*mapReflect).v
 | |
| }
 | |
| 
 | |
| func (c *mapConverter) IsValidPB(v protoreflect.Value) bool {
 | |
| 	mapv, ok := v.Interface().(*mapReflect)
 | |
| 	if !ok {
 | |
| 		return false
 | |
| 	}
 | |
| 	return mapv.v.Type() == c.goType
 | |
| }
 | |
| 
 | |
| func (c *mapConverter) IsValidGo(v reflect.Value) bool {
 | |
| 	return v.IsValid() && v.Type() == c.goType
 | |
| }
 | |
| 
 | |
| func (c *mapConverter) New() protoreflect.Value {
 | |
| 	return c.PBValueOf(reflect.MakeMap(c.goType))
 | |
| }
 | |
| 
 | |
| func (c *mapConverter) Zero() protoreflect.Value {
 | |
| 	return c.PBValueOf(reflect.Zero(c.goType))
 | |
| }
 | |
| 
 | |
| type mapReflect struct {
 | |
| 	v       reflect.Value // map[K]V
 | |
| 	keyConv Converter
 | |
| 	valConv Converter
 | |
| }
 | |
| 
 | |
| func (ms *mapReflect) Len() int {
 | |
| 	return ms.v.Len()
 | |
| }
 | |
| func (ms *mapReflect) Has(k protoreflect.MapKey) bool {
 | |
| 	rk := ms.keyConv.GoValueOf(k.Value())
 | |
| 	rv := ms.v.MapIndex(rk)
 | |
| 	return rv.IsValid()
 | |
| }
 | |
| func (ms *mapReflect) Get(k protoreflect.MapKey) protoreflect.Value {
 | |
| 	rk := ms.keyConv.GoValueOf(k.Value())
 | |
| 	rv := ms.v.MapIndex(rk)
 | |
| 	if !rv.IsValid() {
 | |
| 		return protoreflect.Value{}
 | |
| 	}
 | |
| 	return ms.valConv.PBValueOf(rv)
 | |
| }
 | |
| func (ms *mapReflect) Set(k protoreflect.MapKey, v protoreflect.Value) {
 | |
| 	rk := ms.keyConv.GoValueOf(k.Value())
 | |
| 	rv := ms.valConv.GoValueOf(v)
 | |
| 	ms.v.SetMapIndex(rk, rv)
 | |
| }
 | |
| func (ms *mapReflect) Clear(k protoreflect.MapKey) {
 | |
| 	rk := ms.keyConv.GoValueOf(k.Value())
 | |
| 	ms.v.SetMapIndex(rk, reflect.Value{})
 | |
| }
 | |
| func (ms *mapReflect) Mutable(k protoreflect.MapKey) protoreflect.Value {
 | |
| 	if _, ok := ms.valConv.(*messageConverter); !ok {
 | |
| 		panic("invalid Mutable on map with non-message value type")
 | |
| 	}
 | |
| 	v := ms.Get(k)
 | |
| 	if !v.IsValid() {
 | |
| 		v = ms.NewValue()
 | |
| 		ms.Set(k, v)
 | |
| 	}
 | |
| 	return v
 | |
| }
 | |
| func (ms *mapReflect) Range(f func(protoreflect.MapKey, protoreflect.Value) bool) {
 | |
| 	iter := mapRange(ms.v)
 | |
| 	for iter.Next() {
 | |
| 		k := ms.keyConv.PBValueOf(iter.Key()).MapKey()
 | |
| 		v := ms.valConv.PBValueOf(iter.Value())
 | |
| 		if !f(k, v) {
 | |
| 			return
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| func (ms *mapReflect) NewValue() protoreflect.Value {
 | |
| 	return ms.valConv.New()
 | |
| }
 | |
| func (ms *mapReflect) IsValid() bool {
 | |
| 	return !ms.v.IsNil()
 | |
| }
 | |
| func (ms *mapReflect) protoUnwrap() any {
 | |
| 	return ms.v.Interface()
 | |
| }
 |