 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			148 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			148 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
|    Copyright The containerd Authors.
 | |
| 
 | |
|    Licensed under the Apache License, Version 2.0 (the "License");
 | |
|    you may not use this file except in compliance with the License.
 | |
|    You may obtain a copy of the License at
 | |
| 
 | |
|        http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
|    Unless required by applicable law or agreed to in writing, software
 | |
|    distributed under the License is distributed on an "AS IS" BASIS,
 | |
|    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
|    See the License for the specific language governing permissions and
 | |
|    limitations under the License.
 | |
| */
 | |
| 
 | |
| package errdefs
 | |
| 
 | |
| import "context"
 | |
| 
 | |
| // Resolve returns the first error found in the error chain which matches an
 | |
| // error defined in this package or context error. A raw, unwrapped error is
 | |
| // returned or ErrUnknown if no matching error is found.
 | |
| //
 | |
| // This is useful for determining a response code based on the outermost wrapped
 | |
| // error rather than the original cause. For example, a not found error deep
 | |
| // in the code may be wrapped as an invalid argument. When determining status
 | |
| // code from Is* functions, the depth or ordering of the error is not
 | |
| // considered.
 | |
| //
 | |
| // The search order is depth first, a wrapped error returned from any part of
 | |
| // the chain from `Unwrap() error` will be returned before any joined errors
 | |
| // as returned by `Unwrap() []error`.
 | |
| func Resolve(err error) error {
 | |
| 	if err == nil {
 | |
| 		return nil
 | |
| 	}
 | |
| 	err = firstError(err)
 | |
| 	if err == nil {
 | |
| 		err = ErrUnknown
 | |
| 	}
 | |
| 	return err
 | |
| }
 | |
| 
 | |
| func firstError(err error) error {
 | |
| 	for {
 | |
| 		switch err {
 | |
| 		case ErrUnknown,
 | |
| 			ErrInvalidArgument,
 | |
| 			ErrNotFound,
 | |
| 			ErrAlreadyExists,
 | |
| 			ErrPermissionDenied,
 | |
| 			ErrResourceExhausted,
 | |
| 			ErrFailedPrecondition,
 | |
| 			ErrConflict,
 | |
| 			ErrNotModified,
 | |
| 			ErrAborted,
 | |
| 			ErrOutOfRange,
 | |
| 			ErrNotImplemented,
 | |
| 			ErrInternal,
 | |
| 			ErrUnavailable,
 | |
| 			ErrDataLoss,
 | |
| 			ErrUnauthenticated,
 | |
| 			context.DeadlineExceeded,
 | |
| 			context.Canceled:
 | |
| 			return err
 | |
| 		}
 | |
| 		switch e := err.(type) {
 | |
| 		case customMessage:
 | |
| 			err = e.err
 | |
| 		case unknown:
 | |
| 			return ErrUnknown
 | |
| 		case invalidParameter:
 | |
| 			return ErrInvalidArgument
 | |
| 		case notFound:
 | |
| 			return ErrNotFound
 | |
| 		case alreadyExists:
 | |
| 			return ErrAlreadyExists
 | |
| 		case forbidden:
 | |
| 			return ErrPermissionDenied
 | |
| 		case resourceExhausted:
 | |
| 			return ErrResourceExhausted
 | |
| 		case failedPrecondition:
 | |
| 			return ErrFailedPrecondition
 | |
| 		case conflict:
 | |
| 			return ErrConflict
 | |
| 		case notModified:
 | |
| 			return ErrNotModified
 | |
| 		case aborted:
 | |
| 			return ErrAborted
 | |
| 		case errOutOfRange:
 | |
| 			return ErrOutOfRange
 | |
| 		case notImplemented:
 | |
| 			return ErrNotImplemented
 | |
| 		case system:
 | |
| 			return ErrInternal
 | |
| 		case unavailable:
 | |
| 			return ErrUnavailable
 | |
| 		case dataLoss:
 | |
| 			return ErrDataLoss
 | |
| 		case unauthorized:
 | |
| 			return ErrUnauthenticated
 | |
| 		case deadlineExceeded:
 | |
| 			return context.DeadlineExceeded
 | |
| 		case cancelled:
 | |
| 			return context.Canceled
 | |
| 		case interface{ Unwrap() error }:
 | |
| 			err = e.Unwrap()
 | |
| 			if err == nil {
 | |
| 				return nil
 | |
| 			}
 | |
| 		case interface{ Unwrap() []error }:
 | |
| 			for _, ue := range e.Unwrap() {
 | |
| 				if fe := firstError(ue); fe != nil {
 | |
| 					return fe
 | |
| 				}
 | |
| 			}
 | |
| 			return nil
 | |
| 		case interface{ Is(error) bool }:
 | |
| 			for _, target := range []error{ErrUnknown,
 | |
| 				ErrInvalidArgument,
 | |
| 				ErrNotFound,
 | |
| 				ErrAlreadyExists,
 | |
| 				ErrPermissionDenied,
 | |
| 				ErrResourceExhausted,
 | |
| 				ErrFailedPrecondition,
 | |
| 				ErrConflict,
 | |
| 				ErrNotModified,
 | |
| 				ErrAborted,
 | |
| 				ErrOutOfRange,
 | |
| 				ErrNotImplemented,
 | |
| 				ErrInternal,
 | |
| 				ErrUnavailable,
 | |
| 				ErrDataLoss,
 | |
| 				ErrUnauthenticated,
 | |
| 				context.DeadlineExceeded,
 | |
| 				context.Canceled} {
 | |
| 				if e.Is(target) {
 | |
| 					return target
 | |
| 				}
 | |
| 			}
 | |
| 			return nil
 | |
| 		default:
 | |
| 			return nil
 | |
| 		}
 | |
| 	}
 | |
| }
 |