 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			82 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			82 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package assert
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"reflect"
 | |
| )
 | |
| 
 | |
| // isOrdered checks that collection contains orderable elements.
 | |
| func isOrdered(t TestingT, object interface{}, allowedComparesResults []compareResult, failMessage string, msgAndArgs ...interface{}) bool {
 | |
| 	objKind := reflect.TypeOf(object).Kind()
 | |
| 	if objKind != reflect.Slice && objKind != reflect.Array {
 | |
| 		return false
 | |
| 	}
 | |
| 
 | |
| 	objValue := reflect.ValueOf(object)
 | |
| 	objLen := objValue.Len()
 | |
| 
 | |
| 	if objLen <= 1 {
 | |
| 		return true
 | |
| 	}
 | |
| 
 | |
| 	value := objValue.Index(0)
 | |
| 	valueInterface := value.Interface()
 | |
| 	firstValueKind := value.Kind()
 | |
| 
 | |
| 	for i := 1; i < objLen; i++ {
 | |
| 		prevValue := value
 | |
| 		prevValueInterface := valueInterface
 | |
| 
 | |
| 		value = objValue.Index(i)
 | |
| 		valueInterface = value.Interface()
 | |
| 
 | |
| 		compareResult, isComparable := compare(prevValueInterface, valueInterface, firstValueKind)
 | |
| 
 | |
| 		if !isComparable {
 | |
| 			return Fail(t, fmt.Sprintf(`Can not compare type "%T" and "%T"`, value, prevValue), msgAndArgs...)
 | |
| 		}
 | |
| 
 | |
| 		if !containsValue(allowedComparesResults, compareResult) {
 | |
| 			return Fail(t, fmt.Sprintf(failMessage, prevValue, value), msgAndArgs...)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	return true
 | |
| }
 | |
| 
 | |
| // IsIncreasing asserts that the collection is increasing
 | |
| //
 | |
| //	assert.IsIncreasing(t, []int{1, 2, 3})
 | |
| //	assert.IsIncreasing(t, []float{1, 2})
 | |
| //	assert.IsIncreasing(t, []string{"a", "b"})
 | |
| func IsIncreasing(t TestingT, object interface{}, msgAndArgs ...interface{}) bool {
 | |
| 	return isOrdered(t, object, []compareResult{compareLess}, "\"%v\" is not less than \"%v\"", msgAndArgs...)
 | |
| }
 | |
| 
 | |
| // IsNonIncreasing asserts that the collection is not increasing
 | |
| //
 | |
| //	assert.IsNonIncreasing(t, []int{2, 1, 1})
 | |
| //	assert.IsNonIncreasing(t, []float{2, 1})
 | |
| //	assert.IsNonIncreasing(t, []string{"b", "a"})
 | |
| func IsNonIncreasing(t TestingT, object interface{}, msgAndArgs ...interface{}) bool {
 | |
| 	return isOrdered(t, object, []compareResult{compareEqual, compareGreater}, "\"%v\" is not greater than or equal to \"%v\"", msgAndArgs...)
 | |
| }
 | |
| 
 | |
| // IsDecreasing asserts that the collection is decreasing
 | |
| //
 | |
| //	assert.IsDecreasing(t, []int{2, 1, 0})
 | |
| //	assert.IsDecreasing(t, []float{2, 1})
 | |
| //	assert.IsDecreasing(t, []string{"b", "a"})
 | |
| func IsDecreasing(t TestingT, object interface{}, msgAndArgs ...interface{}) bool {
 | |
| 	return isOrdered(t, object, []compareResult{compareGreater}, "\"%v\" is not greater than \"%v\"", msgAndArgs...)
 | |
| }
 | |
| 
 | |
| // IsNonDecreasing asserts that the collection is not decreasing
 | |
| //
 | |
| //	assert.IsNonDecreasing(t, []int{1, 1, 2})
 | |
| //	assert.IsNonDecreasing(t, []float{1, 2})
 | |
| //	assert.IsNonDecreasing(t, []string{"a", "b"})
 | |
| func IsNonDecreasing(t TestingT, object interface{}, msgAndArgs ...interface{}) bool {
 | |
| 	return isOrdered(t, object, []compareResult{compareLess, compareEqual}, "\"%v\" is not less than or equal to \"%v\"", msgAndArgs...)
 | |
| }
 |