 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			166 lines
		
	
	
		
			5.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			166 lines
		
	
	
		
			5.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package assert
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"net/http"
 | |
| 	"net/http/httptest"
 | |
| 	"net/url"
 | |
| 	"strings"
 | |
| )
 | |
| 
 | |
| // httpCode is a helper that returns HTTP code of the response. It returns -1 and
 | |
| // an error if building a new request fails.
 | |
| func httpCode(handler http.HandlerFunc, method, url string, values url.Values) (int, error) {
 | |
| 	w := httptest.NewRecorder()
 | |
| 	req, err := http.NewRequest(method, url, http.NoBody)
 | |
| 	if err != nil {
 | |
| 		return -1, err
 | |
| 	}
 | |
| 	req.URL.RawQuery = values.Encode()
 | |
| 	handler(w, req)
 | |
| 	return w.Code, nil
 | |
| }
 | |
| 
 | |
| // HTTPSuccess asserts that a specified handler returns a success status code.
 | |
| //
 | |
| //	assert.HTTPSuccess(t, myHandler, "POST", "http://www.google.com", nil)
 | |
| //
 | |
| // Returns whether the assertion was successful (true) or not (false).
 | |
| func HTTPSuccess(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, msgAndArgs ...interface{}) bool {
 | |
| 	if h, ok := t.(tHelper); ok {
 | |
| 		h.Helper()
 | |
| 	}
 | |
| 	code, err := httpCode(handler, method, url, values)
 | |
| 	if err != nil {
 | |
| 		Fail(t, fmt.Sprintf("Failed to build test request, got error: %s", err), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	isSuccessCode := code >= http.StatusOK && code <= http.StatusPartialContent
 | |
| 	if !isSuccessCode {
 | |
| 		Fail(t, fmt.Sprintf("Expected HTTP success status code for %q but received %d", url+"?"+values.Encode(), code), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	return isSuccessCode
 | |
| }
 | |
| 
 | |
| // HTTPRedirect asserts that a specified handler returns a redirect status code.
 | |
| //
 | |
| //	assert.HTTPRedirect(t, myHandler, "GET", "/a/b/c", url.Values{"a": []string{"b", "c"}}
 | |
| //
 | |
| // Returns whether the assertion was successful (true) or not (false).
 | |
| func HTTPRedirect(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, msgAndArgs ...interface{}) bool {
 | |
| 	if h, ok := t.(tHelper); ok {
 | |
| 		h.Helper()
 | |
| 	}
 | |
| 	code, err := httpCode(handler, method, url, values)
 | |
| 	if err != nil {
 | |
| 		Fail(t, fmt.Sprintf("Failed to build test request, got error: %s", err), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	isRedirectCode := code >= http.StatusMultipleChoices && code <= http.StatusTemporaryRedirect
 | |
| 	if !isRedirectCode {
 | |
| 		Fail(t, fmt.Sprintf("Expected HTTP redirect status code for %q but received %d", url+"?"+values.Encode(), code), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	return isRedirectCode
 | |
| }
 | |
| 
 | |
| // HTTPError asserts that a specified handler returns an error status code.
 | |
| //
 | |
| //	assert.HTTPError(t, myHandler, "POST", "/a/b/c", url.Values{"a": []string{"b", "c"}}
 | |
| //
 | |
| // Returns whether the assertion was successful (true) or not (false).
 | |
| func HTTPError(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, msgAndArgs ...interface{}) bool {
 | |
| 	if h, ok := t.(tHelper); ok {
 | |
| 		h.Helper()
 | |
| 	}
 | |
| 	code, err := httpCode(handler, method, url, values)
 | |
| 	if err != nil {
 | |
| 		Fail(t, fmt.Sprintf("Failed to build test request, got error: %s", err), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	isErrorCode := code >= http.StatusBadRequest
 | |
| 	if !isErrorCode {
 | |
| 		Fail(t, fmt.Sprintf("Expected HTTP error status code for %q but received %d", url+"?"+values.Encode(), code), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	return isErrorCode
 | |
| }
 | |
| 
 | |
| // HTTPStatusCode asserts that a specified handler returns a specified status code.
 | |
| //
 | |
| //	assert.HTTPStatusCode(t, myHandler, "GET", "/notImplemented", nil, 501)
 | |
| //
 | |
| // Returns whether the assertion was successful (true) or not (false).
 | |
| func HTTPStatusCode(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, statuscode int, msgAndArgs ...interface{}) bool {
 | |
| 	if h, ok := t.(tHelper); ok {
 | |
| 		h.Helper()
 | |
| 	}
 | |
| 	code, err := httpCode(handler, method, url, values)
 | |
| 	if err != nil {
 | |
| 		Fail(t, fmt.Sprintf("Failed to build test request, got error: %s", err), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	successful := code == statuscode
 | |
| 	if !successful {
 | |
| 		Fail(t, fmt.Sprintf("Expected HTTP status code %d for %q but received %d", statuscode, url+"?"+values.Encode(), code), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	return successful
 | |
| }
 | |
| 
 | |
| // HTTPBody is a helper that returns HTTP body of the response. It returns
 | |
| // empty string if building a new request fails.
 | |
| func HTTPBody(handler http.HandlerFunc, method, url string, values url.Values) string {
 | |
| 	w := httptest.NewRecorder()
 | |
| 	if len(values) > 0 {
 | |
| 		url += "?" + values.Encode()
 | |
| 	}
 | |
| 	req, err := http.NewRequest(method, url, http.NoBody)
 | |
| 	if err != nil {
 | |
| 		return ""
 | |
| 	}
 | |
| 	handler(w, req)
 | |
| 	return w.Body.String()
 | |
| }
 | |
| 
 | |
| // HTTPBodyContains asserts that a specified handler returns a
 | |
| // body that contains a string.
 | |
| //
 | |
| //	assert.HTTPBodyContains(t, myHandler, "GET", "www.google.com", nil, "I'm Feeling Lucky")
 | |
| //
 | |
| // Returns whether the assertion was successful (true) or not (false).
 | |
| func HTTPBodyContains(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, str interface{}, msgAndArgs ...interface{}) bool {
 | |
| 	if h, ok := t.(tHelper); ok {
 | |
| 		h.Helper()
 | |
| 	}
 | |
| 	body := HTTPBody(handler, method, url, values)
 | |
| 
 | |
| 	contains := strings.Contains(body, fmt.Sprint(str))
 | |
| 	if !contains {
 | |
| 		Fail(t, fmt.Sprintf("Expected response body for %q to contain %q but found %q", url+"?"+values.Encode(), str, body), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	return contains
 | |
| }
 | |
| 
 | |
| // HTTPBodyNotContains asserts that a specified handler returns a
 | |
| // body that does not contain a string.
 | |
| //
 | |
| //	assert.HTTPBodyNotContains(t, myHandler, "GET", "www.google.com", nil, "I'm Feeling Lucky")
 | |
| //
 | |
| // Returns whether the assertion was successful (true) or not (false).
 | |
| func HTTPBodyNotContains(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, str interface{}, msgAndArgs ...interface{}) bool {
 | |
| 	if h, ok := t.(tHelper); ok {
 | |
| 		h.Helper()
 | |
| 	}
 | |
| 	body := HTTPBody(handler, method, url, values)
 | |
| 
 | |
| 	contains := strings.Contains(body, fmt.Sprint(str))
 | |
| 	if contains {
 | |
| 		Fail(t, fmt.Sprintf("Expected response body for %q to NOT contain %q but found %q", url+"?"+values.Encode(), str, body), msgAndArgs...)
 | |
| 	}
 | |
| 
 | |
| 	return !contains
 | |
| }
 |