 8d9b62daf3
			
		
	
	8d9b62daf3
	
	
	
		
			
			This commit implements Phase 2 of the CHORUS Task Execution Engine development plan, providing a comprehensive execution environment abstraction layer with Docker container sandboxing support. ## New Features ### Core Sandbox Interface - Comprehensive ExecutionSandbox interface with isolated task execution - Support for command execution, file I/O, environment management - Resource usage monitoring and sandbox lifecycle management - Standardized error handling with SandboxError types and categories ### Docker Container Sandbox Implementation - Full Docker API integration with secure container creation - Transparent repository mounting with configurable read/write access - Advanced security policies with capability dropping and privilege controls - Comprehensive resource limits (CPU, memory, disk, processes, file handles) - Support for tmpfs mounts, masked paths, and read-only bind mounts - Container lifecycle management with proper cleanup and health monitoring ### Security & Resource Management - Configurable security policies with SELinux, AppArmor, and Seccomp support - Fine-grained capability management with secure defaults - Network isolation options with configurable DNS and proxy settings - Resource monitoring with real-time CPU, memory, and network usage tracking - Comprehensive ulimits configuration for process and file handle limits ### Repository Integration - Seamless repository mounting from local paths to container workspaces - Git configuration support with user credentials and global settings - File inclusion/exclusion patterns for selective repository access - Configurable permissions and ownership for mounted repositories ### Testing Infrastructure - Comprehensive test suite with 60+ test cases covering all functionality - Docker integration tests with Alpine Linux containers (skipped in short mode) - Mock sandbox implementation for unit testing without Docker dependencies - Security policy validation tests with read-only filesystem enforcement - Resource usage monitoring and cleanup verification tests ## Technical Details ### Dependencies Added - github.com/docker/docker v28.4.0+incompatible - Docker API client - github.com/docker/go-connections v0.6.0 - Docker connection utilities - github.com/docker/go-units v0.5.0 - Docker units and formatting - Associated Docker API dependencies for complete container management ### Architecture - Interface-driven design enabling multiple sandbox implementations - Comprehensive configuration structures for all sandbox aspects - Resource usage tracking with detailed metrics collection - Error handling with retryable error classification - Proper cleanup and resource management throughout sandbox lifecycle ### Compatibility - Maintains backward compatibility with existing CHORUS architecture - Designed for future integration with Phase 3 Core Task Execution Engine - Extensible design supporting additional sandbox implementations (VM, process) This Phase 2 implementation provides the foundation for secure, isolated task execution that will be integrated with the AI model providers from Phase 1 in the upcoming Phase 3 development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			99 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			99 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Go Authors. All rights reserved.
 | |
| // Use of this source code is governed by a BSD-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package proto
 | |
| 
 | |
| import (
 | |
| 	"google.golang.org/protobuf/encoding/protowire"
 | |
| 	"google.golang.org/protobuf/internal/encoding/messageset"
 | |
| 	"google.golang.org/protobuf/internal/errors"
 | |
| 	"google.golang.org/protobuf/internal/flags"
 | |
| 	"google.golang.org/protobuf/internal/order"
 | |
| 	"google.golang.org/protobuf/reflect/protoreflect"
 | |
| 	"google.golang.org/protobuf/reflect/protoregistry"
 | |
| )
 | |
| 
 | |
| func (o MarshalOptions) sizeMessageSet(m protoreflect.Message) (size int) {
 | |
| 	m.Range(func(fd protoreflect.FieldDescriptor, v protoreflect.Value) bool {
 | |
| 		size += messageset.SizeField(fd.Number())
 | |
| 		size += protowire.SizeTag(messageset.FieldMessage)
 | |
| 		size += protowire.SizeBytes(o.size(v.Message()))
 | |
| 		return true
 | |
| 	})
 | |
| 	size += messageset.SizeUnknown(m.GetUnknown())
 | |
| 	return size
 | |
| }
 | |
| 
 | |
| func (o MarshalOptions) marshalMessageSet(b []byte, m protoreflect.Message) ([]byte, error) {
 | |
| 	if !flags.ProtoLegacy {
 | |
| 		return b, errors.New("no support for message_set_wire_format")
 | |
| 	}
 | |
| 	fieldOrder := order.AnyFieldOrder
 | |
| 	if o.Deterministic {
 | |
| 		fieldOrder = order.NumberFieldOrder
 | |
| 	}
 | |
| 	var err error
 | |
| 	order.RangeFields(m, fieldOrder, func(fd protoreflect.FieldDescriptor, v protoreflect.Value) bool {
 | |
| 		b, err = o.marshalMessageSetField(b, fd, v)
 | |
| 		return err == nil
 | |
| 	})
 | |
| 	if err != nil {
 | |
| 		return b, err
 | |
| 	}
 | |
| 	return messageset.AppendUnknown(b, m.GetUnknown())
 | |
| }
 | |
| 
 | |
| func (o MarshalOptions) marshalMessageSetField(b []byte, fd protoreflect.FieldDescriptor, value protoreflect.Value) ([]byte, error) {
 | |
| 	b = messageset.AppendFieldStart(b, fd.Number())
 | |
| 	b = protowire.AppendTag(b, messageset.FieldMessage, protowire.BytesType)
 | |
| 	calculatedSize := o.Size(value.Message().Interface())
 | |
| 	b = protowire.AppendVarint(b, uint64(calculatedSize))
 | |
| 	before := len(b)
 | |
| 	b, err := o.marshalMessage(b, value.Message())
 | |
| 	if err != nil {
 | |
| 		return b, err
 | |
| 	}
 | |
| 	if measuredSize := len(b) - before; calculatedSize != measuredSize {
 | |
| 		return nil, errors.MismatchedSizeCalculation(calculatedSize, measuredSize)
 | |
| 	}
 | |
| 	b = messageset.AppendFieldEnd(b)
 | |
| 	return b, nil
 | |
| }
 | |
| 
 | |
| func (o UnmarshalOptions) unmarshalMessageSet(b []byte, m protoreflect.Message) error {
 | |
| 	if !flags.ProtoLegacy {
 | |
| 		return errors.New("no support for message_set_wire_format")
 | |
| 	}
 | |
| 	return messageset.Unmarshal(b, false, func(num protowire.Number, v []byte) error {
 | |
| 		err := o.unmarshalMessageSetField(m, num, v)
 | |
| 		if err == errUnknown {
 | |
| 			unknown := m.GetUnknown()
 | |
| 			unknown = protowire.AppendTag(unknown, num, protowire.BytesType)
 | |
| 			unknown = protowire.AppendBytes(unknown, v)
 | |
| 			m.SetUnknown(unknown)
 | |
| 			return nil
 | |
| 		}
 | |
| 		return err
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func (o UnmarshalOptions) unmarshalMessageSetField(m protoreflect.Message, num protowire.Number, v []byte) error {
 | |
| 	md := m.Descriptor()
 | |
| 	if !md.ExtensionRanges().Has(num) {
 | |
| 		return errUnknown
 | |
| 	}
 | |
| 	xt, err := o.Resolver.FindExtensionByNumber(md.FullName(), num)
 | |
| 	if err == protoregistry.NotFound {
 | |
| 		return errUnknown
 | |
| 	}
 | |
| 	if err != nil {
 | |
| 		return errors.New("%v: unable to resolve extension %v: %v", md.FullName(), num, err)
 | |
| 	}
 | |
| 	xd := xt.TypeDescriptor()
 | |
| 	if err := o.unmarshalMessage(v, m.Mutable(xd).Message()); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	return nil
 | |
| }
 |