 131868bdca
			
		
	
	131868bdca
	
	
	
		
			
			Major security, observability, and configuration improvements:
## Security Hardening
- Implemented configurable CORS (no more wildcards)
- Added comprehensive auth middleware for admin endpoints
- Enhanced webhook HMAC validation
- Added input validation and rate limiting
- Security headers and CSP policies
## Configuration Management
- Made N8N webhook URL configurable (WHOOSH_N8N_BASE_URL)
- Replaced all hardcoded endpoints with environment variables
- Added feature flags for LLM vs heuristic composition
- Gitea fetch hardening with EAGER_FILTER and FULL_RESCAN options
## API Completeness
- Implemented GetCouncilComposition function
- Added GET /api/v1/councils/{id} endpoint
- Council artifacts API (POST/GET /api/v1/councils/{id}/artifacts)
- /admin/health/details endpoint with component status
- Database lookup for repository URLs (no hardcoded fallbacks)
## Observability & Performance
- Added OpenTelemetry distributed tracing with goal/pulse correlation
- Performance optimization database indexes
- Comprehensive health monitoring
- Enhanced logging and error handling
## Infrastructure
- Production-ready P2P discovery (replaces mock implementation)
- Removed unused Redis configuration
- Enhanced Docker Swarm integration
- Added migration files for performance indexes
## Code Quality
- Comprehensive input validation
- Graceful error handling and failsafe fallbacks
- Backwards compatibility maintained
- Following security best practices
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
		
	
		
			
				
	
	
		
			145 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			145 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| //go:build windows
 | |
| // +build windows
 | |
| 
 | |
| package winio
 | |
| 
 | |
| import (
 | |
| 	"errors"
 | |
| 	"syscall"
 | |
| 	"unsafe"
 | |
| 
 | |
| 	"golang.org/x/sys/windows"
 | |
| )
 | |
| 
 | |
| //sys lookupAccountName(systemName *uint16, accountName string, sid *byte, sidSize *uint32, refDomain *uint16, refDomainSize *uint32, sidNameUse *uint32) (err error) = advapi32.LookupAccountNameW
 | |
| //sys lookupAccountSid(systemName *uint16, sid *byte, name *uint16, nameSize *uint32, refDomain *uint16, refDomainSize *uint32, sidNameUse *uint32) (err error) = advapi32.LookupAccountSidW
 | |
| //sys convertSidToStringSid(sid *byte, str **uint16) (err error) = advapi32.ConvertSidToStringSidW
 | |
| //sys convertStringSidToSid(str *uint16, sid **byte) (err error) = advapi32.ConvertStringSidToSidW
 | |
| //sys convertStringSecurityDescriptorToSecurityDescriptor(str string, revision uint32, sd *uintptr, size *uint32) (err error) = advapi32.ConvertStringSecurityDescriptorToSecurityDescriptorW
 | |
| //sys convertSecurityDescriptorToStringSecurityDescriptor(sd *byte, revision uint32, secInfo uint32, sddl **uint16, sddlSize *uint32) (err error) = advapi32.ConvertSecurityDescriptorToStringSecurityDescriptorW
 | |
| //sys localFree(mem uintptr) = LocalFree
 | |
| //sys getSecurityDescriptorLength(sd uintptr) (len uint32) = advapi32.GetSecurityDescriptorLength
 | |
| 
 | |
| type AccountLookupError struct {
 | |
| 	Name string
 | |
| 	Err  error
 | |
| }
 | |
| 
 | |
| func (e *AccountLookupError) Error() string {
 | |
| 	if e.Name == "" {
 | |
| 		return "lookup account: empty account name specified"
 | |
| 	}
 | |
| 	var s string
 | |
| 	switch {
 | |
| 	case errors.Is(e.Err, windows.ERROR_INVALID_SID):
 | |
| 		s = "the security ID structure is invalid"
 | |
| 	case errors.Is(e.Err, windows.ERROR_NONE_MAPPED):
 | |
| 		s = "not found"
 | |
| 	default:
 | |
| 		s = e.Err.Error()
 | |
| 	}
 | |
| 	return "lookup account " + e.Name + ": " + s
 | |
| }
 | |
| 
 | |
| func (e *AccountLookupError) Unwrap() error { return e.Err }
 | |
| 
 | |
| type SddlConversionError struct {
 | |
| 	Sddl string
 | |
| 	Err  error
 | |
| }
 | |
| 
 | |
| func (e *SddlConversionError) Error() string {
 | |
| 	return "convert " + e.Sddl + ": " + e.Err.Error()
 | |
| }
 | |
| 
 | |
| func (e *SddlConversionError) Unwrap() error { return e.Err }
 | |
| 
 | |
| // LookupSidByName looks up the SID of an account by name
 | |
| //
 | |
| //revive:disable-next-line:var-naming SID, not Sid
 | |
| func LookupSidByName(name string) (sid string, err error) {
 | |
| 	if name == "" {
 | |
| 		return "", &AccountLookupError{name, windows.ERROR_NONE_MAPPED}
 | |
| 	}
 | |
| 
 | |
| 	var sidSize, sidNameUse, refDomainSize uint32
 | |
| 	err = lookupAccountName(nil, name, nil, &sidSize, nil, &refDomainSize, &sidNameUse)
 | |
| 	if err != nil && err != syscall.ERROR_INSUFFICIENT_BUFFER { //nolint:errorlint // err is Errno
 | |
| 		return "", &AccountLookupError{name, err}
 | |
| 	}
 | |
| 	sidBuffer := make([]byte, sidSize)
 | |
| 	refDomainBuffer := make([]uint16, refDomainSize)
 | |
| 	err = lookupAccountName(nil, name, &sidBuffer[0], &sidSize, &refDomainBuffer[0], &refDomainSize, &sidNameUse)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{name, err}
 | |
| 	}
 | |
| 	var strBuffer *uint16
 | |
| 	err = convertSidToStringSid(&sidBuffer[0], &strBuffer)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{name, err}
 | |
| 	}
 | |
| 	sid = syscall.UTF16ToString((*[0xffff]uint16)(unsafe.Pointer(strBuffer))[:])
 | |
| 	localFree(uintptr(unsafe.Pointer(strBuffer)))
 | |
| 	return sid, nil
 | |
| }
 | |
| 
 | |
| // LookupNameBySid looks up the name of an account by SID
 | |
| //
 | |
| //revive:disable-next-line:var-naming SID, not Sid
 | |
| func LookupNameBySid(sid string) (name string, err error) {
 | |
| 	if sid == "" {
 | |
| 		return "", &AccountLookupError{sid, windows.ERROR_NONE_MAPPED}
 | |
| 	}
 | |
| 
 | |
| 	sidBuffer, err := windows.UTF16PtrFromString(sid)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 
 | |
| 	var sidPtr *byte
 | |
| 	if err = convertStringSidToSid(sidBuffer, &sidPtr); err != nil {
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 	defer localFree(uintptr(unsafe.Pointer(sidPtr)))
 | |
| 
 | |
| 	var nameSize, refDomainSize, sidNameUse uint32
 | |
| 	err = lookupAccountSid(nil, sidPtr, nil, &nameSize, nil, &refDomainSize, &sidNameUse)
 | |
| 	if err != nil && err != windows.ERROR_INSUFFICIENT_BUFFER { //nolint:errorlint // err is Errno
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 
 | |
| 	nameBuffer := make([]uint16, nameSize)
 | |
| 	refDomainBuffer := make([]uint16, refDomainSize)
 | |
| 	err = lookupAccountSid(nil, sidPtr, &nameBuffer[0], &nameSize, &refDomainBuffer[0], &refDomainSize, &sidNameUse)
 | |
| 	if err != nil {
 | |
| 		return "", &AccountLookupError{sid, err}
 | |
| 	}
 | |
| 
 | |
| 	name = windows.UTF16ToString(nameBuffer)
 | |
| 	return name, nil
 | |
| }
 | |
| 
 | |
| func SddlToSecurityDescriptor(sddl string) ([]byte, error) {
 | |
| 	var sdBuffer uintptr
 | |
| 	err := convertStringSecurityDescriptorToSecurityDescriptor(sddl, 1, &sdBuffer, nil)
 | |
| 	if err != nil {
 | |
| 		return nil, &SddlConversionError{sddl, err}
 | |
| 	}
 | |
| 	defer localFree(sdBuffer)
 | |
| 	sd := make([]byte, getSecurityDescriptorLength(sdBuffer))
 | |
| 	copy(sd, (*[0xffff]byte)(unsafe.Pointer(sdBuffer))[:len(sd)])
 | |
| 	return sd, nil
 | |
| }
 | |
| 
 | |
| func SecurityDescriptorToSddl(sd []byte) (string, error) {
 | |
| 	var sddl *uint16
 | |
| 	// The returned string length seems to include an arbitrary number of terminating NULs.
 | |
| 	// Don't use it.
 | |
| 	err := convertSecurityDescriptorToStringSecurityDescriptor(&sd[0], 1, 0xff, &sddl, nil)
 | |
| 	if err != nil {
 | |
| 		return "", err
 | |
| 	}
 | |
| 	defer localFree(uintptr(unsafe.Pointer(sddl)))
 | |
| 	return syscall.UTF16ToString((*[0xffff]uint16)(unsafe.Pointer(sddl))[:]), nil
 | |
| }
 |