 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			100 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			100 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| 'use strict';
 | |
| 
 | |
| import {VERSION} from '../env/data.js';
 | |
| import AxiosError from '../core/AxiosError.js';
 | |
| 
 | |
| const validators = {};
 | |
| 
 | |
| // eslint-disable-next-line func-names
 | |
| ['object', 'boolean', 'number', 'function', 'string', 'symbol'].forEach((type, i) => {
 | |
|   validators[type] = function validator(thing) {
 | |
|     return typeof thing === type || 'a' + (i < 1 ? 'n ' : ' ') + type;
 | |
|   };
 | |
| });
 | |
| 
 | |
| const deprecatedWarnings = {};
 | |
| 
 | |
| /**
 | |
|  * Transitional option validator
 | |
|  *
 | |
|  * @param {function|boolean?} validator - set to false if the transitional option has been removed
 | |
|  * @param {string?} version - deprecated version / removed since version
 | |
|  * @param {string?} message - some message with additional info
 | |
|  *
 | |
|  * @returns {function}
 | |
|  */
 | |
| validators.transitional = function transitional(validator, version, message) {
 | |
|   function formatMessage(opt, desc) {
 | |
|     return '[Axios v' + VERSION + '] Transitional option \'' + opt + '\'' + desc + (message ? '. ' + message : '');
 | |
|   }
 | |
| 
 | |
|   // eslint-disable-next-line func-names
 | |
|   return (value, opt, opts) => {
 | |
|     if (validator === false) {
 | |
|       throw new AxiosError(
 | |
|         formatMessage(opt, ' has been removed' + (version ? ' in ' + version : '')),
 | |
|         AxiosError.ERR_DEPRECATED
 | |
|       );
 | |
|     }
 | |
| 
 | |
|     if (version && !deprecatedWarnings[opt]) {
 | |
|       deprecatedWarnings[opt] = true;
 | |
|       // eslint-disable-next-line no-console
 | |
|       console.warn(
 | |
|         formatMessage(
 | |
|           opt,
 | |
|           ' has been deprecated since v' + version + ' and will be removed in the near future'
 | |
|         )
 | |
|       );
 | |
|     }
 | |
| 
 | |
|     return validator ? validator(value, opt, opts) : true;
 | |
|   };
 | |
| };
 | |
| 
 | |
| validators.spelling = function spelling(correctSpelling) {
 | |
|   return (value, opt) => {
 | |
|     // eslint-disable-next-line no-console
 | |
|     console.warn(`${opt} is likely a misspelling of ${correctSpelling}`);
 | |
|     return true;
 | |
|   }
 | |
| };
 | |
| 
 | |
| /**
 | |
|  * Assert object's properties type
 | |
|  *
 | |
|  * @param {object} options
 | |
|  * @param {object} schema
 | |
|  * @param {boolean?} allowUnknown
 | |
|  *
 | |
|  * @returns {object}
 | |
|  */
 | |
| 
 | |
| function assertOptions(options, schema, allowUnknown) {
 | |
|   if (typeof options !== 'object') {
 | |
|     throw new AxiosError('options must be an object', AxiosError.ERR_BAD_OPTION_VALUE);
 | |
|   }
 | |
|   const keys = Object.keys(options);
 | |
|   let i = keys.length;
 | |
|   while (i-- > 0) {
 | |
|     const opt = keys[i];
 | |
|     const validator = schema[opt];
 | |
|     if (validator) {
 | |
|       const value = options[opt];
 | |
|       const result = value === undefined || validator(value, opt, options);
 | |
|       if (result !== true) {
 | |
|         throw new AxiosError('option ' + opt + ' must be ' + result, AxiosError.ERR_BAD_OPTION_VALUE);
 | |
|       }
 | |
|       continue;
 | |
|     }
 | |
|     if (allowUnknown !== true) {
 | |
|       throw new AxiosError('Unknown option ' + opt, AxiosError.ERR_BAD_OPTION);
 | |
|     }
 | |
|   }
 | |
| }
 | |
| 
 | |
| export default {
 | |
|   assertOptions,
 | |
|   validators
 | |
| };
 |