This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
99 lines
3.0 KiB
JavaScript
99 lines
3.0 KiB
JavaScript
'use strict';
|
|
|
|
const prompts = require('./prompts');
|
|
|
|
const passOn = ['suggest', 'format', 'onState', 'validate', 'onRender', 'type'];
|
|
const noop = () => {};
|
|
|
|
/**
|
|
* Prompt for a series of questions
|
|
* @param {Array|Object} questions Single question object or Array of question objects
|
|
* @param {Function} [onSubmit] Callback function called on prompt submit
|
|
* @param {Function} [onCancel] Callback function called on cancel/abort
|
|
* @returns {Object} Object with values from user input
|
|
*/
|
|
async function prompt(questions=[], { onSubmit=noop, onCancel=noop }={}) {
|
|
const answers = {};
|
|
const override = prompt._override || {};
|
|
questions = [].concat(questions);
|
|
let answer, question, quit, name, type, lastPrompt;
|
|
|
|
const getFormattedAnswer = async (question, answer, skipValidation = false) => {
|
|
if (!skipValidation && question.validate && question.validate(answer) !== true) {
|
|
return;
|
|
}
|
|
return question.format ? await question.format(answer, answers) : answer
|
|
};
|
|
|
|
for (question of questions) {
|
|
({ name, type } = question);
|
|
|
|
// evaluate type first and skip if type is a falsy value
|
|
if (typeof type === 'function') {
|
|
type = await type(answer, { ...answers }, question)
|
|
question['type'] = type
|
|
}
|
|
if (!type) continue;
|
|
|
|
// if property is a function, invoke it unless it's a special function
|
|
for (let key in question) {
|
|
if (passOn.includes(key)) continue;
|
|
let value = question[key];
|
|
question[key] = typeof value === 'function' ? await value(answer, { ...answers }, lastPrompt) : value;
|
|
}
|
|
|
|
lastPrompt = question;
|
|
|
|
if (typeof question.message !== 'string') {
|
|
throw new Error('prompt message is required');
|
|
}
|
|
|
|
// update vars in case they changed
|
|
({ name, type } = question);
|
|
|
|
if (prompts[type] === void 0) {
|
|
throw new Error(`prompt type (${type}) is not defined`);
|
|
}
|
|
|
|
if (override[question.name] !== undefined) {
|
|
answer = await getFormattedAnswer(question, override[question.name]);
|
|
if (answer !== undefined) {
|
|
answers[name] = answer;
|
|
continue;
|
|
}
|
|
}
|
|
|
|
try {
|
|
// Get the injected answer if there is one or prompt the user
|
|
answer = prompt._injected ? getInjectedAnswer(prompt._injected, question.initial) : await prompts[type](question);
|
|
answers[name] = answer = await getFormattedAnswer(question, answer, true);
|
|
quit = await onSubmit(question, answer, answers);
|
|
} catch (err) {
|
|
quit = !(await onCancel(question, answers));
|
|
}
|
|
|
|
if (quit) return answers;
|
|
}
|
|
|
|
return answers;
|
|
}
|
|
|
|
function getInjectedAnswer(injected, deafultValue) {
|
|
const answer = injected.shift();
|
|
if (answer instanceof Error) {
|
|
throw answer;
|
|
}
|
|
|
|
return (answer === undefined) ? deafultValue : answer;
|
|
}
|
|
|
|
function inject(answers) {
|
|
prompt._injected = (prompt._injected || []).concat(answers);
|
|
}
|
|
|
|
function override(answers) {
|
|
prompt._override = Object.assign({}, answers);
|
|
}
|
|
|
|
module.exports = Object.assign(prompt, { prompt, prompts, inject, override });
|