 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			209 lines
		
	
	
		
			4.6 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			209 lines
		
	
	
		
			4.6 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| var util = require('util');
 | |
| var Stream = require('stream').Stream;
 | |
| var DelayedStream = require('delayed-stream');
 | |
| 
 | |
| module.exports = CombinedStream;
 | |
| function CombinedStream() {
 | |
|   this.writable = false;
 | |
|   this.readable = true;
 | |
|   this.dataSize = 0;
 | |
|   this.maxDataSize = 2 * 1024 * 1024;
 | |
|   this.pauseStreams = true;
 | |
| 
 | |
|   this._released = false;
 | |
|   this._streams = [];
 | |
|   this._currentStream = null;
 | |
|   this._insideLoop = false;
 | |
|   this._pendingNext = false;
 | |
| }
 | |
| util.inherits(CombinedStream, Stream);
 | |
| 
 | |
| CombinedStream.create = function(options) {
 | |
|   var combinedStream = new this();
 | |
| 
 | |
|   options = options || {};
 | |
|   for (var option in options) {
 | |
|     combinedStream[option] = options[option];
 | |
|   }
 | |
| 
 | |
|   return combinedStream;
 | |
| };
 | |
| 
 | |
| CombinedStream.isStreamLike = function(stream) {
 | |
|   return (typeof stream !== 'function')
 | |
|     && (typeof stream !== 'string')
 | |
|     && (typeof stream !== 'boolean')
 | |
|     && (typeof stream !== 'number')
 | |
|     && (!Buffer.isBuffer(stream));
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype.append = function(stream) {
 | |
|   var isStreamLike = CombinedStream.isStreamLike(stream);
 | |
| 
 | |
|   if (isStreamLike) {
 | |
|     if (!(stream instanceof DelayedStream)) {
 | |
|       var newStream = DelayedStream.create(stream, {
 | |
|         maxDataSize: Infinity,
 | |
|         pauseStream: this.pauseStreams,
 | |
|       });
 | |
|       stream.on('data', this._checkDataSize.bind(this));
 | |
|       stream = newStream;
 | |
|     }
 | |
| 
 | |
|     this._handleErrors(stream);
 | |
| 
 | |
|     if (this.pauseStreams) {
 | |
|       stream.pause();
 | |
|     }
 | |
|   }
 | |
| 
 | |
|   this._streams.push(stream);
 | |
|   return this;
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype.pipe = function(dest, options) {
 | |
|   Stream.prototype.pipe.call(this, dest, options);
 | |
|   this.resume();
 | |
|   return dest;
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._getNext = function() {
 | |
|   this._currentStream = null;
 | |
| 
 | |
|   if (this._insideLoop) {
 | |
|     this._pendingNext = true;
 | |
|     return; // defer call
 | |
|   }
 | |
| 
 | |
|   this._insideLoop = true;
 | |
|   try {
 | |
|     do {
 | |
|       this._pendingNext = false;
 | |
|       this._realGetNext();
 | |
|     } while (this._pendingNext);
 | |
|   } finally {
 | |
|     this._insideLoop = false;
 | |
|   }
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._realGetNext = function() {
 | |
|   var stream = this._streams.shift();
 | |
| 
 | |
| 
 | |
|   if (typeof stream == 'undefined') {
 | |
|     this.end();
 | |
|     return;
 | |
|   }
 | |
| 
 | |
|   if (typeof stream !== 'function') {
 | |
|     this._pipeNext(stream);
 | |
|     return;
 | |
|   }
 | |
| 
 | |
|   var getStream = stream;
 | |
|   getStream(function(stream) {
 | |
|     var isStreamLike = CombinedStream.isStreamLike(stream);
 | |
|     if (isStreamLike) {
 | |
|       stream.on('data', this._checkDataSize.bind(this));
 | |
|       this._handleErrors(stream);
 | |
|     }
 | |
| 
 | |
|     this._pipeNext(stream);
 | |
|   }.bind(this));
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._pipeNext = function(stream) {
 | |
|   this._currentStream = stream;
 | |
| 
 | |
|   var isStreamLike = CombinedStream.isStreamLike(stream);
 | |
|   if (isStreamLike) {
 | |
|     stream.on('end', this._getNext.bind(this));
 | |
|     stream.pipe(this, {end: false});
 | |
|     return;
 | |
|   }
 | |
| 
 | |
|   var value = stream;
 | |
|   this.write(value);
 | |
|   this._getNext();
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._handleErrors = function(stream) {
 | |
|   var self = this;
 | |
|   stream.on('error', function(err) {
 | |
|     self._emitError(err);
 | |
|   });
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype.write = function(data) {
 | |
|   this.emit('data', data);
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype.pause = function() {
 | |
|   if (!this.pauseStreams) {
 | |
|     return;
 | |
|   }
 | |
| 
 | |
|   if(this.pauseStreams && this._currentStream && typeof(this._currentStream.pause) == 'function') this._currentStream.pause();
 | |
|   this.emit('pause');
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype.resume = function() {
 | |
|   if (!this._released) {
 | |
|     this._released = true;
 | |
|     this.writable = true;
 | |
|     this._getNext();
 | |
|   }
 | |
| 
 | |
|   if(this.pauseStreams && this._currentStream && typeof(this._currentStream.resume) == 'function') this._currentStream.resume();
 | |
|   this.emit('resume');
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype.end = function() {
 | |
|   this._reset();
 | |
|   this.emit('end');
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype.destroy = function() {
 | |
|   this._reset();
 | |
|   this.emit('close');
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._reset = function() {
 | |
|   this.writable = false;
 | |
|   this._streams = [];
 | |
|   this._currentStream = null;
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._checkDataSize = function() {
 | |
|   this._updateDataSize();
 | |
|   if (this.dataSize <= this.maxDataSize) {
 | |
|     return;
 | |
|   }
 | |
| 
 | |
|   var message =
 | |
|     'DelayedStream#maxDataSize of ' + this.maxDataSize + ' bytes exceeded.';
 | |
|   this._emitError(new Error(message));
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._updateDataSize = function() {
 | |
|   this.dataSize = 0;
 | |
| 
 | |
|   var self = this;
 | |
|   this._streams.forEach(function(stream) {
 | |
|     if (!stream.dataSize) {
 | |
|       return;
 | |
|     }
 | |
| 
 | |
|     self.dataSize += stream.dataSize;
 | |
|   });
 | |
| 
 | |
|   if (this._currentStream && this._currentStream.dataSize) {
 | |
|     this.dataSize += this._currentStream.dataSize;
 | |
|   }
 | |
| };
 | |
| 
 | |
| CombinedStream.prototype._emitError = function(err) {
 | |
|   this._reset();
 | |
|   this.emit('error', err);
 | |
| };
 |