 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			172 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			172 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| 'use strict';
 | |
| 
 | |
| var traverse = require('../index');
 | |
| var assert = require('assert');
 | |
| 
 | |
| describe('json-schema-traverse', function() {
 | |
|   var calls;
 | |
| 
 | |
|   beforeEach(function() {
 | |
|     calls = [];
 | |
|   });
 | |
| 
 | |
|   it('should traverse all keywords containing schemas recursively', function() {
 | |
|     var schema = require('./fixtures/schema').schema;
 | |
|     var expectedCalls = require('./fixtures/schema').expectedCalls;
 | |
| 
 | |
|     traverse(schema, {cb: callback});
 | |
|     assert.deepStrictEqual(calls, expectedCalls);
 | |
|   });
 | |
| 
 | |
|   describe('Legacy v0.3.1 API', function() {
 | |
|     it('should traverse all keywords containing schemas recursively', function() {
 | |
|       var schema = require('./fixtures/schema').schema;
 | |
|       var expectedCalls = require('./fixtures/schema').expectedCalls;
 | |
| 
 | |
|       traverse(schema, callback);
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
| 
 | |
|     it('should work when an options object is provided', function() {
 | |
|       // schema, jsonPtr, rootSchema, parentJsonPtr, parentKeyword, parentSchema, keyIndex
 | |
|       var schema = require('./fixtures/schema').schema;
 | |
|       var expectedCalls = require('./fixtures/schema').expectedCalls;
 | |
| 
 | |
|       traverse(schema, {}, callback);
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
|   });
 | |
| 
 | |
| 
 | |
|   describe('allKeys option', function() {
 | |
|     var schema = {
 | |
|       someObject: {
 | |
|         minimum: 1,
 | |
|         maximum: 2
 | |
|       }
 | |
|     };
 | |
| 
 | |
|     it('should traverse objects with allKeys: true option', function() {
 | |
|       // schema, jsonPtr, rootSchema, parentJsonPtr, parentKeyword, parentSchema, keyIndex
 | |
|       var expectedCalls = [
 | |
|         [schema, '', schema, undefined, undefined, undefined, undefined],
 | |
|         [schema.someObject, '/someObject', schema, '', 'someObject', schema, undefined]
 | |
|       ];
 | |
| 
 | |
|       traverse(schema, {allKeys: true, cb: callback});
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
| 
 | |
| 
 | |
|     it('should NOT traverse objects with allKeys: false option', function() {
 | |
|       // schema, jsonPtr, rootSchema, parentJsonPtr, parentKeyword, parentSchema, keyIndex
 | |
|       var expectedCalls = [
 | |
|         [schema, '', schema, undefined, undefined, undefined, undefined]
 | |
|       ];
 | |
| 
 | |
|       traverse(schema, {allKeys: false, cb: callback});
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
| 
 | |
| 
 | |
|     it('should NOT traverse objects without allKeys option', function() {
 | |
|       // schema, jsonPtr, rootSchema, parentJsonPtr, parentKeyword, parentSchema, keyIndex
 | |
|       var expectedCalls = [
 | |
|         [schema, '', schema, undefined, undefined, undefined, undefined]
 | |
|       ];
 | |
| 
 | |
|       traverse(schema, {cb: callback});
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
| 
 | |
| 
 | |
|     it('should NOT travers objects in standard keywords which value is not a schema', function() {
 | |
|       var schema2 = {
 | |
|         const: {foo: 'bar'},
 | |
|         enum: ['a', 'b'],
 | |
|         required: ['foo'],
 | |
|         another: {
 | |
| 
 | |
|         },
 | |
|         patternProperties: {}, // will not traverse - no properties
 | |
|         dependencies: true, // will not traverse - invalid
 | |
|         properties: {
 | |
|           smaller: {
 | |
|             type: 'number'
 | |
|           },
 | |
|           larger: {
 | |
|             type: 'number',
 | |
|             minimum: {$data: '1/smaller'}
 | |
|           }
 | |
|         }
 | |
|       };
 | |
| 
 | |
|       // schema, jsonPtr, rootSchema, parentJsonPtr, parentKeyword, parentSchema, keyIndex
 | |
|       var expectedCalls = [
 | |
|         [schema2, '', schema2, undefined, undefined, undefined, undefined],
 | |
|         [schema2.another, '/another', schema2, '', 'another', schema2, undefined],
 | |
|         [schema2.properties.smaller, '/properties/smaller', schema2, '', 'properties', schema2, 'smaller'],
 | |
|         [schema2.properties.larger, '/properties/larger', schema2, '', 'properties', schema2, 'larger'],
 | |
|       ];
 | |
| 
 | |
|       traverse(schema2, {allKeys: true, cb: callback});
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   describe('pre and post', function() {
 | |
|     var schema = {
 | |
|       type: 'object',
 | |
|       properties: {
 | |
|         name: {type: 'string'},
 | |
|         age: {type: 'number'}
 | |
|       }
 | |
|     };
 | |
| 
 | |
|     it('should traverse schema in pre-order', function() {
 | |
|       traverse(schema, {cb: {pre}});
 | |
|       var expectedCalls = [
 | |
|         ['pre', schema, '', schema, undefined, undefined, undefined, undefined],
 | |
|         ['pre', schema.properties.name, '/properties/name', schema, '', 'properties', schema, 'name'],
 | |
|         ['pre', schema.properties.age, '/properties/age', schema, '', 'properties', schema, 'age'],
 | |
|       ];
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
| 
 | |
|     it('should traverse schema in post-order', function() {
 | |
|       traverse(schema, {cb: {post}});
 | |
|       var expectedCalls = [
 | |
|         ['post', schema.properties.name, '/properties/name', schema, '', 'properties', schema, 'name'],
 | |
|         ['post', schema.properties.age, '/properties/age', schema, '', 'properties', schema, 'age'],
 | |
|         ['post', schema, '', schema, undefined, undefined, undefined, undefined],
 | |
|       ];
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
| 
 | |
|     it('should traverse schema in pre- and post-order at the same time', function() {
 | |
|       traverse(schema, {cb: {pre, post}});
 | |
|       var expectedCalls = [
 | |
|         ['pre', schema, '', schema, undefined, undefined, undefined, undefined],
 | |
|         ['pre', schema.properties.name, '/properties/name', schema, '', 'properties', schema, 'name'],
 | |
|         ['post', schema.properties.name, '/properties/name', schema, '', 'properties', schema, 'name'],
 | |
|         ['pre', schema.properties.age, '/properties/age', schema, '', 'properties', schema, 'age'],
 | |
|         ['post', schema.properties.age, '/properties/age', schema, '', 'properties', schema, 'age'],
 | |
|         ['post', schema, '', schema, undefined, undefined, undefined, undefined],
 | |
|       ];
 | |
|       assert.deepStrictEqual(calls, expectedCalls);
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   function callback() {
 | |
|     calls.push(Array.prototype.slice.call(arguments));
 | |
|   }
 | |
| 
 | |
|   function pre() {
 | |
|     calls.push(['pre'].concat(Array.prototype.slice.call(arguments)));
 | |
|   }
 | |
| 
 | |
|   function post() {
 | |
|     calls.push(['post'].concat(Array.prototype.slice.call(arguments)));
 | |
|   }
 | |
| });
 |