 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			81 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			81 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| 'use strict';
 | |
| module.exports = function generate__limitItems(it, $keyword, $ruleType) {
 | |
|   var out = ' ';
 | |
|   var $lvl = it.level;
 | |
|   var $dataLvl = it.dataLevel;
 | |
|   var $schema = it.schema[$keyword];
 | |
|   var $schemaPath = it.schemaPath + it.util.getProperty($keyword);
 | |
|   var $errSchemaPath = it.errSchemaPath + '/' + $keyword;
 | |
|   var $breakOnError = !it.opts.allErrors;
 | |
|   var $errorKeyword;
 | |
|   var $data = 'data' + ($dataLvl || '');
 | |
|   var $isData = it.opts.$data && $schema && $schema.$data,
 | |
|     $schemaValue;
 | |
|   if ($isData) {
 | |
|     out += ' var schema' + ($lvl) + ' = ' + (it.util.getData($schema.$data, $dataLvl, it.dataPathArr)) + '; ';
 | |
|     $schemaValue = 'schema' + $lvl;
 | |
|   } else {
 | |
|     $schemaValue = $schema;
 | |
|   }
 | |
|   if (!($isData || typeof $schema == 'number')) {
 | |
|     throw new Error($keyword + ' must be number');
 | |
|   }
 | |
|   var $op = $keyword == 'maxItems' ? '>' : '<';
 | |
|   out += 'if ( ';
 | |
|   if ($isData) {
 | |
|     out += ' (' + ($schemaValue) + ' !== undefined && typeof ' + ($schemaValue) + ' != \'number\') || ';
 | |
|   }
 | |
|   out += ' ' + ($data) + '.length ' + ($op) + ' ' + ($schemaValue) + ') { ';
 | |
|   var $errorKeyword = $keyword;
 | |
|   var $$outStack = $$outStack || [];
 | |
|   $$outStack.push(out);
 | |
|   out = ''; /* istanbul ignore else */
 | |
|   if (it.createErrors !== false) {
 | |
|     out += ' { keyword: \'' + ($errorKeyword || '_limitItems') + '\' , dataPath: (dataPath || \'\') + ' + (it.errorPath) + ' , schemaPath: ' + (it.util.toQuotedString($errSchemaPath)) + ' , params: { limit: ' + ($schemaValue) + ' } ';
 | |
|     if (it.opts.messages !== false) {
 | |
|       out += ' , message: \'should NOT have ';
 | |
|       if ($keyword == 'maxItems') {
 | |
|         out += 'more';
 | |
|       } else {
 | |
|         out += 'fewer';
 | |
|       }
 | |
|       out += ' than ';
 | |
|       if ($isData) {
 | |
|         out += '\' + ' + ($schemaValue) + ' + \'';
 | |
|       } else {
 | |
|         out += '' + ($schema);
 | |
|       }
 | |
|       out += ' items\' ';
 | |
|     }
 | |
|     if (it.opts.verbose) {
 | |
|       out += ' , schema:  ';
 | |
|       if ($isData) {
 | |
|         out += 'validate.schema' + ($schemaPath);
 | |
|       } else {
 | |
|         out += '' + ($schema);
 | |
|       }
 | |
|       out += '         , parentSchema: validate.schema' + (it.schemaPath) + ' , data: ' + ($data) + ' ';
 | |
|     }
 | |
|     out += ' } ';
 | |
|   } else {
 | |
|     out += ' {} ';
 | |
|   }
 | |
|   var __err = out;
 | |
|   out = $$outStack.pop();
 | |
|   if (!it.compositeRule && $breakOnError) {
 | |
|     /* istanbul ignore if */
 | |
|     if (it.async) {
 | |
|       out += ' throw new ValidationError([' + (__err) + ']); ';
 | |
|     } else {
 | |
|       out += ' validate.errors = [' + (__err) + ']; return false; ';
 | |
|     }
 | |
|   } else {
 | |
|     out += ' var err = ' + (__err) + ';  if (vErrors === null) vErrors = [err]; else vErrors.push(err); errors++; ';
 | |
|   }
 | |
|   out += '} ';
 | |
|   if ($breakOnError) {
 | |
|     out += ' else { ';
 | |
|   }
 | |
|   return out;
 | |
| }
 |