 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			147 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			147 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| 'use strict';
 | |
| 
 | |
| var IDENTIFIER = /^[a-z_$][a-z0-9_$-]*$/i;
 | |
| var customRuleCode = require('./dotjs/custom');
 | |
| var definitionSchema = require('./definition_schema');
 | |
| 
 | |
| module.exports = {
 | |
|   add: addKeyword,
 | |
|   get: getKeyword,
 | |
|   remove: removeKeyword,
 | |
|   validate: validateKeyword
 | |
| };
 | |
| 
 | |
| 
 | |
| /**
 | |
|  * Define custom keyword
 | |
|  * @this  Ajv
 | |
|  * @param {String} keyword custom keyword, should be unique (including different from all standard, custom and macro keywords).
 | |
|  * @param {Object} definition keyword definition object with properties `type` (type(s) which the keyword applies to), `validate` or `compile`.
 | |
|  * @return {Ajv} this for method chaining
 | |
|  */
 | |
| function addKeyword(keyword, definition) {
 | |
|   /* jshint validthis: true */
 | |
|   /* eslint no-shadow: 0 */
 | |
|   var RULES = this.RULES;
 | |
|   if (RULES.keywords[keyword])
 | |
|     throw new Error('Keyword ' + keyword + ' is already defined');
 | |
| 
 | |
|   if (!IDENTIFIER.test(keyword))
 | |
|     throw new Error('Keyword ' + keyword + ' is not a valid identifier');
 | |
| 
 | |
|   if (definition) {
 | |
|     this.validateKeyword(definition, true);
 | |
| 
 | |
|     var dataType = definition.type;
 | |
|     if (Array.isArray(dataType)) {
 | |
|       for (var i=0; i<dataType.length; i++)
 | |
|         _addRule(keyword, dataType[i], definition);
 | |
|     } else {
 | |
|       _addRule(keyword, dataType, definition);
 | |
|     }
 | |
| 
 | |
|     var metaSchema = definition.metaSchema;
 | |
|     if (metaSchema) {
 | |
|       if (definition.$data && this._opts.$data) {
 | |
|         metaSchema = {
 | |
|           anyOf: [
 | |
|             metaSchema,
 | |
|             { '$ref': 'https://raw.githubusercontent.com/ajv-validator/ajv/master/lib/refs/data.json#' }
 | |
|           ]
 | |
|         };
 | |
|       }
 | |
|       definition.validateSchema = this.compile(metaSchema, true);
 | |
|     }
 | |
|   }
 | |
| 
 | |
|   RULES.keywords[keyword] = RULES.all[keyword] = true;
 | |
| 
 | |
| 
 | |
|   function _addRule(keyword, dataType, definition) {
 | |
|     var ruleGroup;
 | |
|     for (var i=0; i<RULES.length; i++) {
 | |
|       var rg = RULES[i];
 | |
|       if (rg.type == dataType) {
 | |
|         ruleGroup = rg;
 | |
|         break;
 | |
|       }
 | |
|     }
 | |
| 
 | |
|     if (!ruleGroup) {
 | |
|       ruleGroup = { type: dataType, rules: [] };
 | |
|       RULES.push(ruleGroup);
 | |
|     }
 | |
| 
 | |
|     var rule = {
 | |
|       keyword: keyword,
 | |
|       definition: definition,
 | |
|       custom: true,
 | |
|       code: customRuleCode,
 | |
|       implements: definition.implements
 | |
|     };
 | |
|     ruleGroup.rules.push(rule);
 | |
|     RULES.custom[keyword] = rule;
 | |
|   }
 | |
| 
 | |
|   return this;
 | |
| }
 | |
| 
 | |
| 
 | |
| /**
 | |
|  * Get keyword
 | |
|  * @this  Ajv
 | |
|  * @param {String} keyword pre-defined or custom keyword.
 | |
|  * @return {Object|Boolean} custom keyword definition, `true` if it is a predefined keyword, `false` otherwise.
 | |
|  */
 | |
| function getKeyword(keyword) {
 | |
|   /* jshint validthis: true */
 | |
|   var rule = this.RULES.custom[keyword];
 | |
|   return rule ? rule.definition : this.RULES.keywords[keyword] || false;
 | |
| }
 | |
| 
 | |
| 
 | |
| /**
 | |
|  * Remove keyword
 | |
|  * @this  Ajv
 | |
|  * @param {String} keyword pre-defined or custom keyword.
 | |
|  * @return {Ajv} this for method chaining
 | |
|  */
 | |
| function removeKeyword(keyword) {
 | |
|   /* jshint validthis: true */
 | |
|   var RULES = this.RULES;
 | |
|   delete RULES.keywords[keyword];
 | |
|   delete RULES.all[keyword];
 | |
|   delete RULES.custom[keyword];
 | |
|   for (var i=0; i<RULES.length; i++) {
 | |
|     var rules = RULES[i].rules;
 | |
|     for (var j=0; j<rules.length; j++) {
 | |
|       if (rules[j].keyword == keyword) {
 | |
|         rules.splice(j, 1);
 | |
|         break;
 | |
|       }
 | |
|     }
 | |
|   }
 | |
|   return this;
 | |
| }
 | |
| 
 | |
| 
 | |
| /**
 | |
|  * Validate keyword definition
 | |
|  * @this  Ajv
 | |
|  * @param {Object} definition keyword definition object.
 | |
|  * @param {Boolean} throwError true to throw exception if definition is invalid
 | |
|  * @return {boolean} validation result
 | |
|  */
 | |
| function validateKeyword(definition, throwError) {
 | |
|   validateKeyword.errors = null;
 | |
|   var v = this._validateKeyword = this._validateKeyword
 | |
|                                   || this.compile(definitionSchema, true);
 | |
| 
 | |
|   if (v(definition)) return true;
 | |
|   validateKeyword.errors = v.errors;
 | |
|   if (throwError)
 | |
|     throw new Error('custom keyword definition is invalid: '  + this.errorsText(v.errors));
 | |
|   else
 | |
|     return false;
 | |
| }
 |