 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			74 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			74 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| //compile doT templates to js functions
 | |
| 'use strict';
 | |
| 
 | |
| var glob = require('glob')
 | |
|   , fs = require('fs')
 | |
|   , path = require('path')
 | |
|   , doT = require('dot')
 | |
|   , beautify = require('js-beautify').js_beautify;
 | |
| 
 | |
| var defsRootPath = process.argv[2] || path.join(__dirname, '../lib');
 | |
| 
 | |
| var defs = {};
 | |
| var defFiles = glob.sync('./dot/**/*.def', { cwd: defsRootPath });
 | |
| defFiles.forEach(function (f) {
 | |
|   var name = path.basename(f, '.def');
 | |
|   defs[name] = fs.readFileSync(path.join(defsRootPath, f));
 | |
| });
 | |
| 
 | |
| var filesRootPath = process.argv[3] || path.join(__dirname, '../lib');
 | |
| var files = glob.sync('./dot/**/*.jst', { cwd: filesRootPath });
 | |
| 
 | |
| var dotjsPath = path.join(filesRootPath, './dotjs');
 | |
| try { fs.mkdirSync(dotjsPath); } catch(e) {}
 | |
| 
 | |
| console.log('\n\nCompiling:');
 | |
| 
 | |
| var FUNCTION_NAME = /function\s+anonymous\s*\(it[^)]*\)\s*{/;
 | |
| var OUT_EMPTY_STRING = /out\s*\+=\s*'\s*';/g;
 | |
| var ISTANBUL = /'(istanbul[^']+)';/g;
 | |
| var ERROR_KEYWORD = /\$errorKeyword/g;
 | |
| var ERROR_KEYWORD_OR = /\$errorKeyword\s+\|\|/g;
 | |
| var VARS = [
 | |
|   '$errs', '$valid', '$lvl', '$data', '$dataLvl',
 | |
|   '$errorKeyword', '$closingBraces', '$schemaPath',
 | |
|   '$validate'
 | |
| ];
 | |
| 
 | |
| files.forEach(function (f) {
 | |
|   var keyword = path.basename(f, '.jst');
 | |
|   var targetPath = path.join(dotjsPath, keyword + '.js');
 | |
|   var template = fs.readFileSync(path.join(filesRootPath, f));
 | |
|   var code = doT.compile(template, defs);
 | |
|   code = code.toString()
 | |
|              .replace(OUT_EMPTY_STRING, '')
 | |
|              .replace(FUNCTION_NAME, 'function generate_' + keyword + '(it, $keyword, $ruleType) {')
 | |
|              .replace(ISTANBUL, '/* $1 */');
 | |
|   removeAlwaysFalsyInOr();
 | |
|   VARS.forEach(removeUnusedVar);
 | |
|   code = "'use strict';\nmodule.exports = " + code;
 | |
|   code = beautify(code, { indent_size: 2 }) + '\n';
 | |
|   fs.writeFileSync(targetPath, code);
 | |
|   console.log('compiled', keyword);
 | |
| 
 | |
|   function removeUnusedVar(v) {
 | |
|     v = v.replace(/\$/g, '\\$$');
 | |
|     var regexp = new RegExp(v + '[^A-Za-z0-9_$]', 'g');
 | |
|     var count = occurrences(regexp);
 | |
|     if (count == 1) {
 | |
|       regexp = new RegExp('var\\s+' + v + '\\s*=[^;]+;|var\\s+' + v + ';');
 | |
|       code = code.replace(regexp, '');
 | |
|     }
 | |
|   }
 | |
| 
 | |
|   function removeAlwaysFalsyInOr() {
 | |
|     var countUsed = occurrences(ERROR_KEYWORD);
 | |
|     var countOr = occurrences(ERROR_KEYWORD_OR);
 | |
|     if (countUsed == countOr + 1) code = code.replace(ERROR_KEYWORD_OR, '');
 | |
|   }
 | |
| 
 | |
|   function occurrences(regexp) {
 | |
|     return (code.match(regexp) || []).length;
 | |
|   }
 | |
| });
 |