 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			217 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			217 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| import { RFC1738 } from "./formats.mjs";
 | |
| const has = Object.prototype.hasOwnProperty;
 | |
| const is_array = Array.isArray;
 | |
| const hex_table = (() => {
 | |
|     const array = [];
 | |
|     for (let i = 0; i < 256; ++i) {
 | |
|         array.push('%' + ((i < 16 ? '0' : '') + i.toString(16)).toUpperCase());
 | |
|     }
 | |
|     return array;
 | |
| })();
 | |
| function compact_queue(queue) {
 | |
|     while (queue.length > 1) {
 | |
|         const item = queue.pop();
 | |
|         if (!item)
 | |
|             continue;
 | |
|         const obj = item.obj[item.prop];
 | |
|         if (is_array(obj)) {
 | |
|             const compacted = [];
 | |
|             for (let j = 0; j < obj.length; ++j) {
 | |
|                 if (typeof obj[j] !== 'undefined') {
 | |
|                     compacted.push(obj[j]);
 | |
|                 }
 | |
|             }
 | |
|             // @ts-ignore
 | |
|             item.obj[item.prop] = compacted;
 | |
|         }
 | |
|     }
 | |
| }
 | |
| function array_to_object(source, options) {
 | |
|     const obj = options && options.plainObjects ? Object.create(null) : {};
 | |
|     for (let i = 0; i < source.length; ++i) {
 | |
|         if (typeof source[i] !== 'undefined') {
 | |
|             obj[i] = source[i];
 | |
|         }
 | |
|     }
 | |
|     return obj;
 | |
| }
 | |
| export function merge(target, source, options = {}) {
 | |
|     if (!source) {
 | |
|         return target;
 | |
|     }
 | |
|     if (typeof source !== 'object') {
 | |
|         if (is_array(target)) {
 | |
|             target.push(source);
 | |
|         }
 | |
|         else if (target && typeof target === 'object') {
 | |
|             if ((options && (options.plainObjects || options.allowPrototypes)) ||
 | |
|                 !has.call(Object.prototype, source)) {
 | |
|                 target[source] = true;
 | |
|             }
 | |
|         }
 | |
|         else {
 | |
|             return [target, source];
 | |
|         }
 | |
|         return target;
 | |
|     }
 | |
|     if (!target || typeof target !== 'object') {
 | |
|         return [target].concat(source);
 | |
|     }
 | |
|     let mergeTarget = target;
 | |
|     if (is_array(target) && !is_array(source)) {
 | |
|         // @ts-ignore
 | |
|         mergeTarget = array_to_object(target, options);
 | |
|     }
 | |
|     if (is_array(target) && is_array(source)) {
 | |
|         source.forEach(function (item, i) {
 | |
|             if (has.call(target, i)) {
 | |
|                 const targetItem = target[i];
 | |
|                 if (targetItem && typeof targetItem === 'object' && item && typeof item === 'object') {
 | |
|                     target[i] = merge(targetItem, item, options);
 | |
|                 }
 | |
|                 else {
 | |
|                     target.push(item);
 | |
|                 }
 | |
|             }
 | |
|             else {
 | |
|                 target[i] = item;
 | |
|             }
 | |
|         });
 | |
|         return target;
 | |
|     }
 | |
|     return Object.keys(source).reduce(function (acc, key) {
 | |
|         const value = source[key];
 | |
|         if (has.call(acc, key)) {
 | |
|             acc[key] = merge(acc[key], value, options);
 | |
|         }
 | |
|         else {
 | |
|             acc[key] = value;
 | |
|         }
 | |
|         return acc;
 | |
|     }, mergeTarget);
 | |
| }
 | |
| export function assign_single_source(target, source) {
 | |
|     return Object.keys(source).reduce(function (acc, key) {
 | |
|         acc[key] = source[key];
 | |
|         return acc;
 | |
|     }, target);
 | |
| }
 | |
| export function decode(str, _, charset) {
 | |
|     const strWithoutPlus = str.replace(/\+/g, ' ');
 | |
|     if (charset === 'iso-8859-1') {
 | |
|         // unescape never throws, no try...catch needed:
 | |
|         return strWithoutPlus.replace(/%[0-9a-f]{2}/gi, unescape);
 | |
|     }
 | |
|     // utf-8
 | |
|     try {
 | |
|         return decodeURIComponent(strWithoutPlus);
 | |
|     }
 | |
|     catch (e) {
 | |
|         return strWithoutPlus;
 | |
|     }
 | |
| }
 | |
| const limit = 1024;
 | |
| export const encode = (str, _defaultEncoder, charset, _kind, format) => {
 | |
|     // This code was originally written by Brian White for the io.js core querystring library.
 | |
|     // It has been adapted here for stricter adherence to RFC 3986
 | |
|     if (str.length === 0) {
 | |
|         return str;
 | |
|     }
 | |
|     let string = str;
 | |
|     if (typeof str === 'symbol') {
 | |
|         string = Symbol.prototype.toString.call(str);
 | |
|     }
 | |
|     else if (typeof str !== 'string') {
 | |
|         string = String(str);
 | |
|     }
 | |
|     if (charset === 'iso-8859-1') {
 | |
|         return escape(string).replace(/%u[0-9a-f]{4}/gi, function ($0) {
 | |
|             return '%26%23' + parseInt($0.slice(2), 16) + '%3B';
 | |
|         });
 | |
|     }
 | |
|     let out = '';
 | |
|     for (let j = 0; j < string.length; j += limit) {
 | |
|         const segment = string.length >= limit ? string.slice(j, j + limit) : string;
 | |
|         const arr = [];
 | |
|         for (let i = 0; i < segment.length; ++i) {
 | |
|             let c = segment.charCodeAt(i);
 | |
|             if (c === 0x2d || // -
 | |
|                 c === 0x2e || // .
 | |
|                 c === 0x5f || // _
 | |
|                 c === 0x7e || // ~
 | |
|                 (c >= 0x30 && c <= 0x39) || // 0-9
 | |
|                 (c >= 0x41 && c <= 0x5a) || // a-z
 | |
|                 (c >= 0x61 && c <= 0x7a) || // A-Z
 | |
|                 (format === RFC1738 && (c === 0x28 || c === 0x29)) // ( )
 | |
|             ) {
 | |
|                 arr[arr.length] = segment.charAt(i);
 | |
|                 continue;
 | |
|             }
 | |
|             if (c < 0x80) {
 | |
|                 arr[arr.length] = hex_table[c];
 | |
|                 continue;
 | |
|             }
 | |
|             if (c < 0x800) {
 | |
|                 arr[arr.length] = hex_table[0xc0 | (c >> 6)] + hex_table[0x80 | (c & 0x3f)];
 | |
|                 continue;
 | |
|             }
 | |
|             if (c < 0xd800 || c >= 0xe000) {
 | |
|                 arr[arr.length] =
 | |
|                     hex_table[0xe0 | (c >> 12)] + hex_table[0x80 | ((c >> 6) & 0x3f)] + hex_table[0x80 | (c & 0x3f)];
 | |
|                 continue;
 | |
|             }
 | |
|             i += 1;
 | |
|             c = 0x10000 + (((c & 0x3ff) << 10) | (segment.charCodeAt(i) & 0x3ff));
 | |
|             arr[arr.length] =
 | |
|                 hex_table[0xf0 | (c >> 18)] +
 | |
|                     hex_table[0x80 | ((c >> 12) & 0x3f)] +
 | |
|                     hex_table[0x80 | ((c >> 6) & 0x3f)] +
 | |
|                     hex_table[0x80 | (c & 0x3f)];
 | |
|         }
 | |
|         out += arr.join('');
 | |
|     }
 | |
|     return out;
 | |
| };
 | |
| export function compact(value) {
 | |
|     const queue = [{ obj: { o: value }, prop: 'o' }];
 | |
|     const refs = [];
 | |
|     for (let i = 0; i < queue.length; ++i) {
 | |
|         const item = queue[i];
 | |
|         // @ts-ignore
 | |
|         const obj = item.obj[item.prop];
 | |
|         const keys = Object.keys(obj);
 | |
|         for (let j = 0; j < keys.length; ++j) {
 | |
|             const key = keys[j];
 | |
|             const val = obj[key];
 | |
|             if (typeof val === 'object' && val !== null && refs.indexOf(val) === -1) {
 | |
|                 queue.push({ obj: obj, prop: key });
 | |
|                 refs.push(val);
 | |
|             }
 | |
|         }
 | |
|     }
 | |
|     compact_queue(queue);
 | |
|     return value;
 | |
| }
 | |
| export function is_regexp(obj) {
 | |
|     return Object.prototype.toString.call(obj) === '[object RegExp]';
 | |
| }
 | |
| export function is_buffer(obj) {
 | |
|     if (!obj || typeof obj !== 'object') {
 | |
|         return false;
 | |
|     }
 | |
|     return !!(obj.constructor && obj.constructor.isBuffer && obj.constructor.isBuffer(obj));
 | |
| }
 | |
| export function combine(a, b) {
 | |
|     return [].concat(a, b);
 | |
| }
 | |
| export function maybe_map(val, fn) {
 | |
|     if (is_array(val)) {
 | |
|         const mapped = [];
 | |
|         for (let i = 0; i < val.length; i += 1) {
 | |
|             mapped.push(fn(val[i]));
 | |
|         }
 | |
|         return mapped;
 | |
|     }
 | |
|     return fn(val);
 | |
| }
 | |
| //# sourceMappingURL=utils.mjs.map
 |