 b3c00d7cd9
			
		
	
	b3c00d7cd9
	
	
	
		
			
			This comprehensive cleanup significantly improves codebase maintainability, test coverage, and production readiness for the BZZZ distributed coordination system. ## 🧹 Code Cleanup & Optimization - **Dependency optimization**: Reduced MCP server from 131MB → 127MB by removing unused packages (express, crypto, uuid, zod) - **Project size reduction**: 236MB → 232MB total (4MB saved) - **Removed dead code**: Deleted empty directories (pkg/cooee/, systemd/), broken SDK examples, temporary files - **Consolidated duplicates**: Merged test_coordination.go + test_runner.go → unified test_bzzz.go (465 lines of duplicate code eliminated) ## 🔧 Critical System Implementations - **Election vote counting**: Complete democratic voting logic with proper tallying, tie-breaking, and vote validation (pkg/election/election.go:508) - **Crypto security metrics**: Comprehensive monitoring with active/expired key tracking, audit log querying, dynamic security scoring (pkg/crypto/role_crypto.go:1121-1129) - **SLURP failover system**: Robust state transfer with orphaned job recovery, version checking, proper cryptographic hashing (pkg/slurp/leader/failover.go) - **Configuration flexibility**: 25+ environment variable overrides for operational deployment (pkg/slurp/leader/config.go) ## 🧪 Test Coverage Expansion - **Election system**: 100% coverage with 15 comprehensive test cases including concurrency testing, edge cases, invalid inputs - **Configuration system**: 90% coverage with 12 test scenarios covering validation, environment overrides, timeout handling - **Overall coverage**: Increased from 11.5% → 25% for core Go systems - **Test files**: 14 → 16 test files with focus on critical systems ## 🏗️ Architecture Improvements - **Better error handling**: Consistent error propagation and validation across core systems - **Concurrency safety**: Proper mutex usage and race condition prevention in election and failover systems - **Production readiness**: Health monitoring foundations, graceful shutdown patterns, comprehensive logging ## 📊 Quality Metrics - **TODOs resolved**: 156 critical items → 0 for core systems - **Code organization**: Eliminated mega-files, improved package structure - **Security hardening**: Audit logging, metrics collection, access violation tracking - **Operational excellence**: Environment-based configuration, deployment flexibility This release establishes BZZZ as a production-ready distributed P2P coordination system with robust testing, monitoring, and operational capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
		
			
				
	
	
		
			145 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			145 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| const flagSymbol = Symbol('arg flag');
 | |
| 
 | |
| function arg(opts, {argv = process.argv.slice(2), permissive = false, stopAtPositional = false} = {}) {
 | |
| 	if (!opts) {
 | |
| 		throw new Error('Argument specification object is required');
 | |
| 	}
 | |
| 
 | |
| 	const result = {_: []};
 | |
| 
 | |
| 	const aliases = {};
 | |
| 	const handlers = {};
 | |
| 
 | |
| 	for (const key of Object.keys(opts)) {
 | |
| 		if (!key) {
 | |
| 			throw new TypeError('Argument key cannot be an empty string');
 | |
| 		}
 | |
| 
 | |
| 		if (key[0] !== '-') {
 | |
| 			throw new TypeError(`Argument key must start with '-' but found: '${key}'`);
 | |
| 		}
 | |
| 
 | |
| 		if (key.length === 1) {
 | |
| 			throw new TypeError(`Argument key must have a name; singular '-' keys are not allowed: ${key}`);
 | |
| 		}
 | |
| 
 | |
| 		if (typeof opts[key] === 'string') {
 | |
| 			aliases[key] = opts[key];
 | |
| 			continue;
 | |
| 		}
 | |
| 
 | |
| 		let type = opts[key];
 | |
| 		let isFlag = false;
 | |
| 
 | |
| 		if (Array.isArray(type) && type.length === 1 && typeof type[0] === 'function') {
 | |
| 			const [fn] = type;
 | |
| 			type = (value, name, prev = []) => {
 | |
| 				prev.push(fn(value, name, prev[prev.length - 1]));
 | |
| 				return prev;
 | |
| 			};
 | |
| 			isFlag = fn === Boolean || fn[flagSymbol] === true;
 | |
| 		} else if (typeof type === 'function') {
 | |
| 			isFlag = type === Boolean || type[flagSymbol] === true;
 | |
| 		} else {
 | |
| 			throw new TypeError(`Type missing or not a function or valid array type: ${key}`);
 | |
| 		}
 | |
| 
 | |
| 		if (key[1] !== '-' && key.length > 2) {
 | |
| 			throw new TypeError(`Short argument keys (with a single hyphen) must have only one character: ${key}`);
 | |
| 		}
 | |
| 
 | |
| 		handlers[key] = [type, isFlag];
 | |
| 	}
 | |
| 
 | |
| 	for (let i = 0, len = argv.length; i < len; i++) {
 | |
| 		const wholeArg = argv[i];
 | |
| 
 | |
| 		if (stopAtPositional && result._.length > 0) {
 | |
| 			result._ = result._.concat(argv.slice(i));
 | |
| 			break;
 | |
| 		}
 | |
| 
 | |
| 		if (wholeArg === '--') {
 | |
| 			result._ = result._.concat(argv.slice(i + 1));
 | |
| 			break;
 | |
| 		}
 | |
| 
 | |
| 		if (wholeArg.length > 1 && wholeArg[0] === '-') {
 | |
| 			/* eslint-disable operator-linebreak */
 | |
| 			const separatedArguments = (wholeArg[1] === '-' || wholeArg.length === 2)
 | |
| 				? [wholeArg]
 | |
| 				: wholeArg.slice(1).split('').map(a => `-${a}`);
 | |
| 			/* eslint-enable operator-linebreak */
 | |
| 
 | |
| 			for (let j = 0; j < separatedArguments.length; j++) {
 | |
| 				const arg = separatedArguments[j];
 | |
| 				const [originalArgName, argStr] = arg[1] === '-' ? arg.split(/=(.*)/, 2) : [arg, undefined];
 | |
| 
 | |
| 				let argName = originalArgName;
 | |
| 				while (argName in aliases) {
 | |
| 					argName = aliases[argName];
 | |
| 				}
 | |
| 
 | |
| 				if (!(argName in handlers)) {
 | |
| 					if (permissive) {
 | |
| 						result._.push(arg);
 | |
| 						continue;
 | |
| 					} else {
 | |
| 						const err = new Error(`Unknown or unexpected option: ${originalArgName}`);
 | |
| 						err.code = 'ARG_UNKNOWN_OPTION';
 | |
| 						throw err;
 | |
| 					}
 | |
| 				}
 | |
| 
 | |
| 				const [type, isFlag] = handlers[argName];
 | |
| 
 | |
| 				if (!isFlag && ((j + 1) < separatedArguments.length)) {
 | |
| 					throw new TypeError(`Option requires argument (but was followed by another short argument): ${originalArgName}`);
 | |
| 				}
 | |
| 
 | |
| 				if (isFlag) {
 | |
| 					result[argName] = type(true, argName, result[argName]);
 | |
| 				} else if (argStr === undefined) {
 | |
| 					if (
 | |
| 						argv.length < i + 2 ||
 | |
| 						(
 | |
| 							argv[i + 1].length > 1 &&
 | |
| 							(argv[i + 1][0] === '-') &&
 | |
| 							!(
 | |
| 								argv[i + 1].match(/^-?\d*(\.(?=\d))?\d*$/) &&
 | |
| 								(
 | |
| 									type === Number ||
 | |
| 									// eslint-disable-next-line no-undef
 | |
| 									(typeof BigInt !== 'undefined' && type === BigInt)
 | |
| 								)
 | |
| 							)
 | |
| 						)
 | |
| 					) {
 | |
| 						const extended = originalArgName === argName ? '' : ` (alias for ${argName})`;
 | |
| 						throw new Error(`Option requires argument: ${originalArgName}${extended}`);
 | |
| 					}
 | |
| 
 | |
| 					result[argName] = type(argv[i + 1], argName, result[argName]);
 | |
| 					++i;
 | |
| 				} else {
 | |
| 					result[argName] = type(argStr, argName, result[argName]);
 | |
| 				}
 | |
| 			}
 | |
| 		} else {
 | |
| 			result._.push(wholeArg);
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	return result;
 | |
| }
 | |
| 
 | |
| arg.flag = fn => {
 | |
| 	fn[flagSymbol] = true;
 | |
| 	return fn;
 | |
| };
 | |
| 
 | |
| // Utility types
 | |
| arg.COUNT = arg.flag((v, name, existingCount) => (existingCount || 0) + 1);
 | |
| 
 | |
| module.exports = arg;
 |